diff --git a/.gn b/.gn index 8a173ba495..e151f7cdc3 100644 --- a/.gn +++ b/.gn @@ -19,10 +19,7 @@ secondary_source = "//build/secondary/" # their includes checked for proper dependencies when you run either # "gn check" or "gn gen --check". # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is done. -check_targets = [ - "//webrtc/voice_engine:level_indicator", - "//webrtc/modules/audio_mixer:audio_conference_mixer", -] +check_targets = [ "//webrtc/voice_engine:level_indicator" ] # These are the list of GN files that run exec_script. This whitelist exists # to force additional review for new uses of exec_script, which is strongly diff --git a/webrtc/modules/audio_mixer/BUILD.gn b/webrtc/modules/audio_mixer/BUILD.gn index 2449c54979..7ef27908be 100644 --- a/webrtc/modules/audio_mixer/BUILD.gn +++ b/webrtc/modules/audio_mixer/BUILD.gn @@ -72,11 +72,9 @@ source_set("audio_conference_mixer") { } deps = [ - "../..:webrtc_common", "../../base:rtc_base_approved", "../../modules/audio_processing", "../../modules/utility", "../../system_wrappers", - "../../system_wrappers:system_wrappers_default", ] } diff --git a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc index 48380fc550..5be76ec4d0 100644 --- a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc +++ b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc @@ -19,6 +19,7 @@ #include "webrtc/modules/utility/include/audio_frame_operations.h" #include "webrtc/system_wrappers/include/critical_section_wrapper.h" #include "webrtc/system_wrappers/include/trace.h" +#include "webrtc/voice_engine/utility.h" namespace webrtc { namespace { @@ -141,8 +142,6 @@ NewAudioConferenceMixerImpl::NewAudioConferenceMixerImpl(int id) thread_checker_.DetachFromThread(); } -NewAudioConferenceMixerImpl::~NewAudioConferenceMixerImpl() {} - bool NewAudioConferenceMixerImpl::Init() { crit_.reset(CriticalSectionWrapper::CreateCriticalSection()); if (crit_.get() == NULL) diff --git a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h index 3933350fed..ef93e6ff91 100644 --- a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h +++ b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h @@ -19,6 +19,7 @@ #include "webrtc/base/thread_checker.h" #include "webrtc/engine_configurations.h" #include "webrtc/modules/audio_mixer/new_audio_conference_mixer.h" +#include "webrtc/modules/audio_conference_mixer/source/memory_pool.h" #include "webrtc/modules/include/module_common_types.h" namespace webrtc { @@ -63,8 +64,6 @@ class NewAudioConferenceMixerImpl : public NewAudioConferenceMixer { explicit NewAudioConferenceMixerImpl(int id); - ~NewAudioConferenceMixerImpl() override; - // Must be called after ctor. bool Init();