admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."

Browse Source 
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed

Original change's description:
> Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
>
> In order to land the component build support in Chromium, it is
> easier to turn on symbols export every time that is_component_build=true
> instead of setting rtc_enable_symbol_export=is_component_build in
> Chromium (since is_component_build is not available in .gn).
>
> rtc_enable_symbol_export is still kept in the mix in order to turn
> on symbol exports in any case a shared library will be added to the
> WebRTC build.
>
> Bug: webrtc:9419
> Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29540}

TBR: kwiberg@webrtc.org
Bug: webrtc:9419
Change-Id: I6a184290f3f1a60c1ed6cbc86aafe3e7df248ce1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158327
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29618}
This commit is contained in:
Mirko Bonadei 2019-10-15 21:25:07 +02:00 committed by Commit Bot
parent e114fb61e1
commit 29db239fed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -111,7 +111,7 @@ config("common_inherited_config") {
cflags = []
ldflags = []
if (rtc_enable_symbol_export) {
if (rtc_enable_symbol_export || is_component_build) {
defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ]
}