admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement RecordingIsInitialized in file_audio_device.cc.

Browse Source 
After https://codereview.webrtc.org/1827263002, audio devices are no
longer (ever) initialized if they return true from
RecordingIsInitialized. Since this was left as "return true;" for
file_audio_device, the recording buffer was never set up correctly, and
the audio buffer would assert when called (in debug) and FileAudioDevice
would cause memory corruption (in release).

BUG=

Review-Url: https://codereview.webrtc.org/2116003003
Cr-Commit-Position: refs/heads/master@{#13489}
This commit is contained in:
noahric 2016-07-15 10:03:54 -07:00 committed by Commit bot
parent 72b7f93e68
commit 28fdf5637f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/audio_device/dummy/file_audio_device.cc
View File

@ -175,7 +175,7 @@ int32_t FileAudioDevice::InitRecording() {
}
bool FileAudioDevice::RecordingIsInitialized() const {
return true;
return _recordingFramesIn10MS != 0;
}
int32_t FileAudioDevice::StartPlayout() {