From 289f13d5acede0701371e0b659ed440b4fbc58da Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Tue, 26 Mar 2019 19:21:37 +0100 Subject: [PATCH] Remove CreateVideoStreamEncoder version that uses GlobalTaskQueueFactory Bug: webrtc:10284 Change-Id: Ic5537fa3d808ef073a7e188fabe2415c7f44c2a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129762 Reviewed-by: Niels Moller Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/master@{#27331} --- api/video/BUILD.gn | 1 - api/video/video_stream_encoder_create.cc | 9 --------- api/video/video_stream_encoder_create.h | 5 ----- 3 files changed, 15 deletions(-) diff --git a/api/video/BUILD.gn b/api/video/BUILD.gn index 33ebd256d2..026d534ed9 100644 --- a/api/video/BUILD.gn +++ b/api/video/BUILD.gn @@ -219,7 +219,6 @@ rtc_source_set("video_stream_encoder_create") { "../../api:scoped_refptr", "../../video:video_stream_encoder_impl", "../task_queue", - "../task_queue:global_task_queue_factory", "../video_codecs:video_codecs_api", "//third_party/abseil-cpp/absl/memory", ] diff --git a/api/video/video_stream_encoder_create.cc b/api/video/video_stream_encoder_create.cc index 875edd9928..c75f20dc36 100644 --- a/api/video/video_stream_encoder_create.cc +++ b/api/video/video_stream_encoder_create.cc @@ -11,19 +11,10 @@ #include "api/video/video_stream_encoder_create.h" #include "absl/memory/memory.h" -#include "api/task_queue/global_task_queue_factory.h" #include "video/overuse_frame_detector.h" #include "video/video_stream_encoder.h" namespace webrtc { -std::unique_ptr CreateVideoStreamEncoder( - uint32_t number_of_cores, - VideoStreamEncoderObserver* encoder_stats_observer, - const VideoStreamEncoderSettings& settings) { - return CreateVideoStreamEncoder(Clock::GetRealTimeClock(), - &GlobalTaskQueueFactory(), number_of_cores, - encoder_stats_observer, settings); -} std::unique_ptr CreateVideoStreamEncoder( Clock* clock, diff --git a/api/video/video_stream_encoder_create.h b/api/video/video_stream_encoder_create.h index 4241626aa7..2d8f29ab2b 100644 --- a/api/video/video_stream_encoder_create.h +++ b/api/video/video_stream_encoder_create.h @@ -25,11 +25,6 @@ namespace webrtc { // TODO(srte): Find a way to avoid this forward declaration. class Clock; -std::unique_ptr CreateVideoStreamEncoder( - uint32_t number_of_cores, - VideoStreamEncoderObserver* encoder_stats_observer, - const VideoStreamEncoderSettings& settings); - std::unique_ptr CreateVideoStreamEncoder( Clock* clock, TaskQueueFactory* task_queue_factory,