Fix -Wunreachable-code-aggressive.

Bug: chromium:1066980
Change-Id: I6888ea1fbc458c9b3063b3f60a7732af16ab5fc9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224266
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#34393}
This commit is contained in:
Peter Kasting 2021-06-29 12:07:08 -07:00 committed by WebRTC LUCI CQ
parent c060ce40bf
commit 286b1db1b2
5 changed files with 2 additions and 23 deletions

View File

@ -47,7 +47,6 @@ absl::optional<VP9Profile> StringToVP9Profile(const std::string& str) {
default: default:
return absl::nullopt; return absl::nullopt;
} }
return absl::nullopt;
} }
absl::optional<VP9Profile> ParseSdpForVP9Profile( absl::optional<VP9Profile> ParseSdpForVP9Profile(

View File

@ -916,7 +916,6 @@ int Resampler::Push(const int16_t* samplesIn,
outLen = (lengthIn * 8) / 11; outLen = (lengthIn * 8) / 11;
free(tmp_mem); free(tmp_mem);
return 0; return 0;
break;
} }
return 0; return 0;
} }

View File

@ -56,10 +56,8 @@ rtc::FunctionView<float(float)> GetActivationFunction(
switch (activation_function) { switch (activation_function) {
case ActivationFunction::kTansigApproximated: case ActivationFunction::kTansigApproximated:
return ::rnnoise::TansigApproximated; return ::rnnoise::TansigApproximated;
break;
case ActivationFunction::kSigmoidApproximated: case ActivationFunction::kSigmoidApproximated:
return ::rnnoise::SigmoidApproximated; return ::rnnoise::SigmoidApproximated;
break;
} }
} }

View File

@ -300,11 +300,6 @@ bool Vp9ReadQp(BitstreamReader* br, FrameInfo* frame_info) {
} }
bool Vp9ReadSegmentationParams(BitstreamReader* br) { bool Vp9ReadSegmentationParams(BitstreamReader* br) {
constexpr int kVp9MaxSegments = 8;
constexpr int kVp9SegLvlMax = 4;
constexpr int kSegmentationFeatureBits[kVp9SegLvlMax] = {8, 6, 2, 0};
constexpr bool kSegmentationFeatureSigned[kVp9SegLvlMax] = {1, 1, 0, 0};
return br->IfNextBoolean([&] { // segmentation_enabled return br->IfNextBoolean([&] { // segmentation_enabled
return br->IfNextBoolean([&] { // update_map return br->IfNextBoolean([&] { // update_map
// Consume probs. // Consume probs.
@ -322,19 +317,6 @@ bool Vp9ReadSegmentationParams(BitstreamReader* br) {
}); });
}); });
}); });
return br->IfNextBoolean([&] {
RETURN_IF_FALSE(br->ConsumeBits(1)); // abs_or_delta
for (int i = 0; i < kVp9MaxSegments; ++i) {
for (int j = 0; j < kVp9SegLvlMax; ++j) {
RETURN_IF_FALSE(br->IfNextBoolean([&] { // feature_enabled
return br->ConsumeBits(kSegmentationFeatureBits[j] +
kSegmentationFeatureSigned[j]);
}));
}
}
return true;
});
} }
bool Vp9ReadTileInfo(BitstreamReader* br, FrameInfo* frame_info) { bool Vp9ReadTileInfo(BitstreamReader* br, FrameInfo* frame_info) {

View File

@ -107,8 +107,9 @@ std::string SequenceCheckerImpl::ExpectationToString() const {
std::string ExpectationToString(const SequenceCheckerImpl* checker) { std::string ExpectationToString(const SequenceCheckerImpl* checker) {
#if RTC_DCHECK_IS_ON #if RTC_DCHECK_IS_ON
return checker->ExpectationToString(); return checker->ExpectationToString();
#endif #else
return std::string(); return std::string();
#endif
} }
} // namespace webrtc_sequence_checker_internal } // namespace webrtc_sequence_checker_internal