From 2869638b4d4931a74ef8b76ab03144bf250cb9e3 Mon Sep 17 00:00:00 2001 From: Jerome Humbert Date: Mon, 13 Jan 2020 08:09:41 +0000 Subject: [PATCH] Avoid [[nodiscard]] warning C4834 with MSVC 2019 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Avoid a warning-as-error of MSVC 2019 due to a test ignoring a [[nodiscard]] return value: C4834: discarding return value of function with 'nodiscard' attribute Change-Id: I6b70d85769f311814393412830f48d0d8bfef63d Bug: webrtc:11275 Change-Id: I6b70d85769f311814393412830f48d0d8bfef63d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164467 Commit-Queue: Patrik Höglund Reviewed-by: Patrik Höglund Cr-Commit-Position: refs/heads/master@{#30226} --- p2p/base/p2p_transport_channel_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2p/base/p2p_transport_channel_unittest.cc b/p2p/base/p2p_transport_channel_unittest.cc index 4b4394d64e..972f7b394b 100644 --- a/p2p/base/p2p_transport_channel_unittest.cc +++ b/p2p/base/p2p_transport_channel_unittest.cc @@ -5639,7 +5639,7 @@ TEST(P2PTransportChannel, InjectIceController) { MockIceControllerFactory factory; FakePortAllocator pa(rtc::Thread::Current(), nullptr); EXPECT_CALL(factory, RecordIceControllerCreated()).Times(1); - std::make_unique( + auto dummy = std::make_unique( "transport_name", /* component= */ 77, &pa, /* async_resolver_factory = */ nullptr,