admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable clang-format in Matlab files

Browse Source 
Matlab files extension is the same as ObjC, which is .m
This makes clang-format think that those files are ObjC and then it
wrongly formats them, leading to output that doesn't compile at all.
It's a known issue and the solution is to disable it in Matlab files.

I don't want to disable ObjC in whole folders, because of 2 reasons:
1) I want ObjC to be properly formatted if new files are added in the
   future
2) C++ header files are interpreted as ObjC and it will disable their
   formatting

According to clang documentation
(https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code), we can disable formatting inline.
However, comments in Matlab are prefixed with `%` and not `//`, so I
thought of a kinda hacky solution, which is `% // clang-format off`, and
it works perfectly.

No-Iwyu: Includes didn't change and it isn't related to formatting
Bug: webrtc:42225392
Change-Id: I281462fd1aecd3ff0428e6ee974514ebabc696ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/374060
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43700}
This commit is contained in:
Boris Tsirkin 2025-01-09 07:26:06 -08:00 committed by WebRTC LUCI CQ
parent c940dba16a
commit 2849146823
6 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/audio_coding/neteq/test/delay_tool/parse_delay_file.m
View File

@ -1,3 +1,4 @@
% // clang-format off
% %
% Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. % Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
% %

1
modules/audio_coding/neteq/test/delay_tool/plot_neteq_delay.m
View File

@ -1,3 +1,4 @@
% // clang-format off
% %
% Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. % Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
% %

1
modules/audio_processing/test/apmtest.m
View File

@ -1,3 +1,4 @@
% // clang-format off
% %
% Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. % Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
% %

1
tools_webrtc/matlab/maxUnwrap.m
View File

@ -1,3 +1,4 @@
% // clang-format off
function sequence = maxUnwrap(sequence, max) function sequence = maxUnwrap(sequence, max)
% %
% sequence = maxUnwrap(sequence, max) % sequence = maxUnwrap(sequence, max)

1
tools_webrtc/matlab/parseLog.m
View File

@ -1,3 +1,4 @@
% // clang-format off
function parsed = parseLog(filename) function parsed = parseLog(filename)
% %
% parsed = parseLog(filename) % parsed = parseLog(filename)

1
tools_webrtc/matlab/rtpAnalyze.m
View File

@ -1,3 +1,4 @@
% // clang-format off
function rtpAnalyze( input_file ) function rtpAnalyze( input_file )
%RTP_ANALYZE Analyze RTP stream(s) from a txt file %RTP_ANALYZE Analyze RTP stream(s) from a txt file
% The function takes the output from the command line tool rtp_analyze % The function takes the output from the command line tool rtp_analyze