From 282dad1943ca0a73e64e39b7d51f0548a9c32ed2 Mon Sep 17 00:00:00 2001 From: Alessio Bazzica Date: Fri, 6 Jul 2018 09:18:09 +0000 Subject: [PATCH] Revert "IWYU: Add for fabsf() and powf()" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 7d47525e8bc11d0e401c2180e0222c1858f8e134. Reason for revert: breaking downstream projects Original change's description: > IWYU: Add for fabsf() and powf() > > Fix the build with libstdc++ after 496cedfe5 ("AEC3: Reverberation model: > Changes on the decay estimation") by including the missing header: > > ../../modules/audio_processing/aec3/reverb_model_estimator.cc: In constructor ‘webrtc::ReverbModelEstimator::ReverbModelEstimator(const webrtc::EchoCanceller3Config&)’: > ../../modules/audio_processing/aec3/reverb_model_estimator.cc:61:21: error: ‘fabsf’ was not declared in this scope > reverb_decay_(fabsf(config.ep_strength.default_len)), > ^~~~~ > ../../modules/audio_processing/aec3/reverb_model_estimator.cc:61:21: note: suggested alternative: ‘labs’ > reverb_decay_(fabsf(config.ep_strength.default_len)), > ^~~~~ > labs > ../../modules/audio_processing/aec3/reverb_model_estimator.cc: In member function ‘void webrtc::ReverbModelEstimator::UpdateReverbDecay(const std::vector&)’: > ../../modules/audio_processing/aec3/reverb_model_estimator.cc:206:15: error: ‘powf’ was not declared in this scope > decay = powf(2.0f, -exp_candidate * kFftLengthBy2); > ^~~~ > > Spotted by Jose Dapena Paz . > > Bug: chromium:819294 > Change-Id: If992e5e473b9d4d0c1b3c1006c3816b7c4eee296 > Reviewed-on: https://webrtc-review.googlesource.com/87241 > Reviewed-by: Jesus de Vicente Pena > Reviewed-by: Gustaf Ullberg > Commit-Queue: Raphael Kubo da Costa (rakuco) > Cr-Commit-Position: refs/heads/master@{#23863} TBR=gustaf@webrtc.org,alessiob@webrtc.org,raphael.kubo.da.costa@intel.com,devicentepena@webrtc.org Change-Id: I8adcec57d67de2efcbf0ebef0cdb700fcc21689a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:819294 Reviewed-on: https://webrtc-review.googlesource.com/87400 Reviewed-by: Alessio Bazzica Commit-Queue: Alessio Bazzica Cr-Commit-Position: refs/heads/master@{#23864} --- modules/audio_processing/aec3/reverb_model_estimator.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/modules/audio_processing/aec3/reverb_model_estimator.cc b/modules/audio_processing/aec3/reverb_model_estimator.cc index 39cb58027d..18b2a845da 100644 --- a/modules/audio_processing/aec3/reverb_model_estimator.cc +++ b/modules/audio_processing/aec3/reverb_model_estimator.cc @@ -10,8 +10,6 @@ #include "modules/audio_processing/aec3/reverb_model_estimator.h" -#include - #include #include #include