diff --git a/pc/peer_connection_ice_unittest.cc b/pc/peer_connection_ice_unittest.cc index f37943f8e4..6fabd51f3a 100644 --- a/pc/peer_connection_ice_unittest.cc +++ b/pc/peer_connection_ice_unittest.cc @@ -497,7 +497,10 @@ TEST_P(PeerConnectionIceTest, DuplicateIceCandidateIgnoredWhenAdded) { EXPECT_EQ(1u, caller->GetIceCandidatesFromRemoteDescription().size()); } -TEST_P(PeerConnectionIceTest, ErrorOnInvalidRemoteIceCandidateAdded) { +// TODO(tommi): Re-enable after updating RTCPeerConnection-blockedPorts.html in +// Chromium (the test needs setRemoteDescription to succeed for an invalid +// candidate). +TEST_P(PeerConnectionIceTest, DISABLED_ErrorOnInvalidRemoteIceCandidateAdded) { auto caller = CreatePeerConnectionWithAudioVideo(); auto callee = CreatePeerConnectionWithAudioVideo(); ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal())); diff --git a/pc/sdp_offer_answer.cc b/pc/sdp_offer_answer.cc index b0a594b66a..4317bca132 100644 --- a/pc/sdp_offer_answer.cc +++ b/pc/sdp_offer_answer.cc @@ -4478,8 +4478,10 @@ bool SdpOfferAnswerHandler::UseCandidate( const cricket::Candidate& c = candidate->candidate(); RTCError error = cricket::VerifyCandidate(c); - if (!error.ok()) - return false; + if (!error.ok()) { + RTC_LOG(LS_WARNING) << "Invalid candidate: " << c.ToString(); + return true; + } pc_->AddRemoteCandidate(result.value()->name, c);