From 27178676cfaf72c17b282a366a1ca190c383757e Mon Sep 17 00:00:00 2001 From: Henrik Kjellander Date: Thu, 12 May 2016 18:24:28 +0200 Subject: [PATCH] UBSan: Suppress openh264 and NetEq errors. As part of the work enabling OpenH264 in WebRTC it was discovered that some of its code triggers an UBSan errors: third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error: shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int') third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out of bounds for type 'VLC [15]' Suppress such errors since this source code is out of our control. This CL also includes a new NetEq suppression. BUG=webrtc:5889 TBR=hbos@webrtc.org Review URL: https://codereview.webrtc.org/1975863002 . Cr-Commit-Position: refs/heads/master@{#12706} --- tools/ubsan/blacklist.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/ubsan/blacklist.txt b/tools/ubsan/blacklist.txt index 1ddbbadb16..7a92cdbcba 100644 --- a/tools/ubsan/blacklist.txt +++ b/tools/ubsan/blacklist.txt @@ -10,6 +10,10 @@ # https://crbug.com/489901 src:*/third_party/yasm/* +# OpenH264 triggers some errors that are out of our control. +src:*/third_party/ffmpeg/libavcodec/* +src:*/third_party/openh264/* + ############################################################################# # Ignore system libraries. src:*/usr/* @@ -33,3 +37,8 @@ fun:*WebRtcSpl_AddSatW32* fun:*WebRtcSpl_SubSatW32* fun:*WebRtcSpl_DivW32HiLow* fun:*GmmProbability* + +############################################################################# +# Ignore errors in peerconnection_unittests. +# https://bugs.chromium.org/p/webrtc/issues/detail?id=5889 +src:*/webrtc/modules/audio_coding/neteq/delay_manager.cc