Clang-tidy fixes in call/

Bug: None
Change-Id: Icfd947848199ca99d667884db2551b164f5d54ab
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/377543
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43937}
This commit is contained in:
Björn Terelius 2025-02-18 17:22:38 +01:00 committed by WebRTC LUCI CQ
parent d650f3c6de
commit 255b09a90a
13 changed files with 17 additions and 8 deletions

View File

@ -13,6 +13,7 @@
#include <algorithm> #include <algorithm>
#include <string> #include <string>
#include <utility> #include <utility>
#include <vector>
#include "absl/strings/string_view.h" #include "absl/strings/string_view.h"
#include "api/make_ref_counted.h" #include "api/make_ref_counted.h"

View File

@ -10,6 +10,7 @@
#include "call/adaptation/encoder_settings.h" #include "call/adaptation/encoder_settings.h"
#include <optional>
#include <utility> #include <utility>
namespace webrtc { namespace webrtc {

View File

@ -11,8 +11,11 @@
#include "call/adaptation/resource_adaptation_processor.h" #include "call/adaptation/resource_adaptation_processor.h"
#include <algorithm> #include <algorithm>
#include <map>
#include <string> #include <string>
#include <tuple>
#include <utility> #include <utility>
#include <vector>
#include "absl/algorithm/container.h" #include "absl/algorithm/container.h"
#include "absl/strings/string_view.h" #include "absl/strings/string_view.h"

View File

@ -10,6 +10,7 @@
#include "call/adaptation/test/fake_adaptation_constraint.h" #include "call/adaptation/test/fake_adaptation_constraint.h"
#include <string>
#include <utility> #include <utility>
#include "absl/strings/string_view.h" #include "absl/strings/string_view.h"

View File

@ -11,6 +11,7 @@
#include "call/adaptation/test/fake_resource.h" #include "call/adaptation/test/fake_resource.h"
#include <algorithm> #include <algorithm>
#include <string>
#include <utility> #include <utility>
#include "absl/strings/string_view.h" #include "absl/strings/string_view.h"

View File

@ -12,6 +12,9 @@
#include <algorithm> #include <algorithm>
#include <limits> #include <limits>
#include <optional>
#include <string>
#include <utility>
#include "rtc_base/checks.h" #include "rtc_base/checks.h"
#include "rtc_base/strings/string_builder.h" #include "rtc_base/strings/string_builder.h"

View File

@ -10,8 +10,9 @@
#include "call/adaptation/video_source_restrictions.h" #include "call/adaptation/video_source_restrictions.h"
#include "test/gtest.h" #include <optional>
#include "test/gtest.h"
namespace webrtc { namespace webrtc {
namespace { namespace {

View File

@ -35,9 +35,7 @@
namespace webrtc { namespace webrtc {
using ::testing::_; using ::testing::_;
using ::testing::DoAll;
using ::testing::Return; using ::testing::Return;
using ::testing::SaveArg;
namespace { namespace {

View File

@ -10,6 +10,8 @@
#include "call/adaptation/video_stream_input_state.h" #include "call/adaptation/video_stream_input_state.h"
#include <optional>
#include "api/video_codecs/video_encoder.h" #include "api/video_codecs/video_encoder.h"
namespace webrtc { namespace webrtc {

View File

@ -67,8 +67,8 @@ class LogObserver {
// Ignore log lines that are due to missing AST extensions, these are // Ignore log lines that are due to missing AST extensions, these are
// logged when we switch back from AST to TOF until the wrapping bitrate // logged when we switch back from AST to TOF until the wrapping bitrate
// estimator gives up on using AST. // estimator gives up on using AST.
if (message.find("BitrateEstimator") != absl::string_view::npos && if (absl::StrContains(message, "BitrateEstimator") &&
message.find("packet is missing") == absl::string_view::npos) { !absl::StrContains(message, "packet is missing")) {
received_log_lines_.push_back(std::string(message)); received_log_lines_.push_back(std::string(message));
} }

View File

@ -55,7 +55,6 @@ namespace webrtc {
namespace { namespace {
using ::testing::_; using ::testing::_;
using ::testing::Contains;
using ::testing::MockFunction; using ::testing::MockFunction;
using ::testing::NiceMock; using ::testing::NiceMock;
using ::testing::StrictMock; using ::testing::StrictMock;

View File

@ -78,7 +78,7 @@ bool CodecPrefersLowerRange(const cricket::Codec& codec) {
std::string profile_id; std::string profile_id;
if (codec.GetParam(cricket::kVP9ProfileId, &profile_id)) { if (codec.GetParam(cricket::kVP9ProfileId, &profile_id)) {
if (profile_id.compare("1") == 0 || profile_id.compare("3") == 0) { if (profile_id == "1" || profile_id == "3") {
return true; return true;
} }
} }

View File

@ -22,7 +22,6 @@ namespace webrtc {
using testing::Eq; using testing::Eq;
using testing::Ge; using testing::Ge;
using testing::Le; using testing::Le;
using testing::Lt;
using testing::Ne; using testing::Ne;
TEST(PayloadTypePicker, PayloadTypeAssignmentWorks) { TEST(PayloadTypePicker, PayloadTypeAssignmentWorks) {