From 2506839dbae49e2c88bcae2734da3ffbe3795a5b Mon Sep 17 00:00:00 2001 From: Bjorn Terelius Date: Thu, 25 Oct 2018 11:07:29 +0200 Subject: [PATCH] Add DCHECK for wrap around in RtpVideoSender::OnBitrateUpdated. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:7510 Change-Id: Idfe645aa75cf6a0699caa94063f47c57c2ed5ee2 Reviewed-on: https://webrtc-review.googlesource.com/c/107728 Commit-Queue: Björn Terelius Reviewed-by: Niels Moller Cr-Commit-Position: refs/heads/master@{#25356} --- call/rtp_video_sender.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/call/rtp_video_sender.cc b/call/rtp_video_sender.cc index daf16f5644..7364cf9fe1 100644 --- a/call/rtp_video_sender.cc +++ b/call/rtp_video_sender.cc @@ -600,12 +600,14 @@ void RtpVideoSender::OnBitrateUpdated(uint32_t bitrate_bps, rtc::CritScope lock(&crit_); uint32_t payload_bitrate_bps = bitrate_bps; if (send_side_bwe_with_overhead_) { - payload_bitrate_bps -= CalculateOverheadRateBps( + uint32_t overhead_bps = CalculateOverheadRateBps( CalculatePacketRate( bitrate_bps, rtp_config_.max_packet_size + transport_overhead_bytes_per_packet_), overhead_bytes_per_packet_ + transport_overhead_bytes_per_packet_, bitrate_bps); + RTC_DCHECK_LE(overhead_bps, bitrate_bps); + payload_bitrate_bps = bitrate_bps - overhead_bps; } // Get the encoder target rate. It is the estimated network rate -