admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use string_view instead of overloading for const string& and const char*

Browse Source 
Bug: none
Change-Id: Ia9e194cfcc2b6489d5d7c84baace67ad423111c2
Reviewed-on: https://webrtc-review.googlesource.com/85982
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24338}
This commit is contained in:
Karl Wiberg 2018-08-15 15:23:08 +02:00 committed by Commit Bot
parent 1c0cf3101d
commit 24744a9b5e
4 changed files with 7 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
DEPS
View File

@ -1046,6 +1046,7 @@ include_rules = [
# Abseil whitelist.
"+absl/container/inlined_vector.h",
"+absl/memory/memory.h",
"+absl/strings/string_view.h",
"+absl/types/optional.h",
"+absl/types/variant.h",
]

1
api/audio_codecs/BUILD.gn
View File

@ -35,6 +35,7 @@ rtc_source_set("audio_codecs_api") {
"../../rtc_base:deprecation",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:sanitizer",
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",
]
}

18
api/audio_codecs/audio_format.cc
View File

@ -17,26 +17,12 @@ namespace webrtc {
SdpAudioFormat::SdpAudioFormat(const SdpAudioFormat&) = default;
SdpAudioFormat::SdpAudioFormat(SdpAudioFormat&&) = default;
SdpAudioFormat::SdpAudioFormat(const char* name,
SdpAudioFormat::SdpAudioFormat(absl::string_view name,
int clockrate_hz,
size_t num_channels)
: name(name), clockrate_hz(clockrate_hz), num_channels(num_channels) {}
SdpAudioFormat::SdpAudioFormat(const std::string& name,
int clockrate_hz,
size_t num_channels)
: name(name), clockrate_hz(clockrate_hz), num_channels(num_channels) {}
SdpAudioFormat::SdpAudioFormat(const char* name,
int clockrate_hz,
size_t num_channels,
const Parameters& param)
: name(name),
clockrate_hz(clockrate_hz),
num_channels(num_channels),
parameters(param) {}
SdpAudioFormat::SdpAudioFormat(const std::string& name,
SdpAudioFormat::SdpAudioFormat(absl::string_view name,
int clockrate_hz,
size_t num_channels,
const Parameters& param)

12
api/audio_codecs/audio_format.h
View File

@ -15,6 +15,7 @@
#include <string>
#include <utility>
#include "absl/strings/string_view.h"
#include "absl/types/optional.h"
#include "rtc_base/checks.h"
@ -27,15 +28,8 @@ struct SdpAudioFormat {
SdpAudioFormat(const SdpAudioFormat&);
SdpAudioFormat(SdpAudioFormat&&);
SdpAudioFormat(const char* name, int clockrate_hz, size_t num_channels);
SdpAudioFormat(const std::string& name,
int clockrate_hz,
size_t num_channels);
SdpAudioFormat(const char* name,
int clockrate_hz,
size_t num_channels,
const Parameters& param);
SdpAudioFormat(const std::string& name,
SdpAudioFormat(absl::string_view name, int clockrate_hz, size_t num_channels);
SdpAudioFormat(absl::string_view name,
int clockrate_hz,
size_t num_channels,
const Parameters& param);