From 245037df093d87c709406564c6266d4e3632cdde Mon Sep 17 00:00:00 2001 From: "henrik.lundin@webrtc.org" Date: Thu, 5 Dec 2013 12:01:45 +0000 Subject: [PATCH] Remove default implementations for SuspendBelowMinBitrate These two methods had default implementations while waiting for changes in libjingle to propagate. Now the changes are in, and the default implementations are removed. BUG=2436 R=mflodman@webrtc.org Review URL: https://webrtc-codereview.appspot.com/5059004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5222 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/video_engine/include/vie_codec.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/webrtc/video_engine/include/vie_codec.h b/webrtc/video_engine/include/vie_codec.h index bddcc3a654..aaf017d2ba 100644 --- a/webrtc/video_engine/include/vie_codec.h +++ b/webrtc/video_engine/include/vie_codec.h @@ -38,8 +38,7 @@ class WEBRTC_DLLEXPORT ViEEncoderObserver { // This method is called whenever the state of the SuspendBelowMinBitrate // changes, i.e., when |is_suspended| toggles. - // TODO(hlundin): Remove the default implementation when possible. - virtual void SuspendChange(int video_channel, bool is_suspended) {} + virtual void SuspendChange(int video_channel, bool is_suspended) = 0; protected: virtual ~ViEEncoderObserver() {} @@ -197,8 +196,7 @@ class WEBRTC_DLLEXPORT ViECodec { // |threshold_bps|, and turns back on when the rate goes back up above // |threshold_bps| + |window_bps|. // This is under development; not tested. - // TODO(hlundin): Remove the default implementation when possible. - virtual void SuspendBelowMinBitrate(int video_channel) {} + virtual void SuspendBelowMinBitrate(int video_channel) = 0; protected: ViECodec() {}