admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Explicitly stop frame delivery in FakePeriodicVideoCapturer.

Browse Source 
There's currently a race while deleting an instance of the
class if frame delivery hasn't been explicitly stopped.

Bug: webrtc:8894
Change-Id: I1c60e6e3f9a3e51b16a21a610d21e33fcf58cc0e
Tbr: kthelgason@webrtc.org
Reviewed-on: https://webrtc-review.googlesource.com/53980
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22039}
This commit is contained in:
Tommi 2018-02-15 17:07:26 +01:00 committed by Commit Bot
parent 4f07bdb255
commit 22bc3f60ce
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pc/test/fakeperiodicvideocapturer.h
View File

@ -42,6 +42,7 @@ class FakePeriodicVideoCapturer
~FakePeriodicVideoCapturer() override {
RTC_DCHECK(main_thread_checker_.CalledOnValidThread());
StopFrameDelivery();
}
// Workaround method for tests to allow stopping frame delivery directly.