admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused method FindDataChannelBySid

Browse Source 
Bug: None
Change-Id: I6e7102872607a3fb52b852832ab01c44514ac1d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259304
Auto-Submit: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36574}
This commit is contained in:
Niels Möller 2022-04-19 16:50:37 +02:00 committed by WebRTC LUCI CQ
parent a6c10e37b0
commit 22b5c3ee4f
4 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pc/data_channel_controller.cc
View File

@ -359,16 +359,6 @@ void DataChannelController::OnTransportChannelClosed(RTCError error) {
} }
} }
SctpDataChannel* DataChannelController::FindDataChannelBySid(int sid) const {
RTC_DCHECK_RUN_ON(signaling_thread());
for (const auto& channel : sctp_data_channels_) {
if (channel->id() == sid) {
return channel;
}
}
return nullptr;
}
DataChannelTransportInterface* DataChannelController::data_channel_transport() DataChannelTransportInterface* DataChannelController::data_channel_transport()
const { const {
// TODO(bugs.webrtc.org/11547): Only allow this accessor to be called on the // TODO(bugs.webrtc.org/11547): Only allow this accessor to be called on the

2
pc/data_channel_controller.h
View File

@ -87,8 +87,6 @@ class DataChannelController : public SctpDataChannelProviderInterface,
config) /* RTC_RUN_ON(signaling_thread()) */; config) /* RTC_RUN_ON(signaling_thread()) */;
void AllocateSctpSids(rtc::SSLRole role); void AllocateSctpSids(rtc::SSLRole role);
SctpDataChannel* FindDataChannelBySid(int sid) const;
// Checks if any data channel has been added. // Checks if any data channel has been added.
bool HasDataChannels() const; bool HasDataChannels() const;
bool HasSctpDataChannels() const { bool HasSctpDataChannels() const {

4
pc/peer_connection.cc
View File

@ -2027,10 +2027,6 @@ void PeerConnection::OnSctpDataChannelClosed(DataChannelInterface* channel) {
static_cast<SctpDataChannel*>(channel)); static_cast<SctpDataChannel*>(channel));
} }
SctpDataChannel* PeerConnection::FindDataChannelBySid(int sid) const {
return data_channel_controller_.FindDataChannelBySid(sid);
}
PeerConnection::InitializePortAllocatorResult PeerConnection::InitializePortAllocatorResult
PeerConnection::InitializePortAllocator_n( PeerConnection::InitializePortAllocator_n(
const cricket::ServerAddresses& stun_servers, const cricket::ServerAddresses& stun_servers,

5
pc/peer_connection.h
View File

@ -494,11 +494,6 @@ class PeerConnection : public PeerConnectionInternal,
void OnNegotiationNeeded(); void OnNegotiationNeeded();
// Returns the specified SCTP DataChannel in sctp_data_channels_,
// or nullptr if not found.
SctpDataChannel* FindDataChannelBySid(int sid) const
RTC_RUN_ON(signaling_thread());
// Called when first configuring the port allocator. // Called when first configuring the port allocator.
struct InitializePortAllocatorResult { struct InitializePortAllocatorResult {
bool enable_ipv6; bool enable_ipv6;