admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Correctly register test field trials in parser unittest

Browse Source 
Previously, field_trial::FindFullName would be called before
field_trial::FieldTrialsAllowedInScopeForTesting was initialized because
member variables will be initialized after the initializer list.

Bug: webrtc:14154
Change-Id: I69098259a21a55a268d5b45949c3ed02e82ae001
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295541
Commit-Queue: Emil Lundmark <lndmrk@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39420}
This commit is contained in:
Emil Lundmark 2023-02-28 16:08:03 +01:00 committed by WebRTC LUCI CQ
parent db1fae46d8
commit 227574804f
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rtc_base/experiments/field_trial_parser_unittest.cc
View File

@ -30,10 +30,12 @@ struct DummyExperiment {
FieldTrialParameter<std::string> hash = FieldTrialParameter<std::string> hash =
FieldTrialParameter<std::string>("h", "a80"); FieldTrialParameter<std::string>("h", "a80");
field_trial::FieldTrialsAllowedInScopeForTesting k{{kDummyExperiment}};
DummyExperiment() DummyExperiment()
: DummyExperiment(field_trial::FindFullName(kDummyExperiment)) {} : DummyExperiment([] {
field_trial::FieldTrialsAllowedInScopeForTesting k{
{kDummyExperiment}};
return field_trial::FindFullName(kDummyExperiment);
}()) {}
explicit DummyExperiment(absl::string_view field_trial) { explicit DummyExperiment(absl::string_view field_trial) {
ParseFieldTrial({&enabled, &factor, &retries, &size, &ping, &hash}, ParseFieldTrial({&enabled, &factor, &retries, &size, &ping, &hash},