From 221ece50cb5100ae991c40e2c008a4f88d300c96 Mon Sep 17 00:00:00 2001 From: Taylor Brandstetter Date: Mon, 14 Dec 2020 14:18:11 -0800 Subject: [PATCH] Correct "DSAWithSHA256" OID. In double checking that the conversion from dot-notation to hex was done correctly for all OIDs, I found an extra character creeped in somehow. This would cause missing certificate stats for certificates with that algorithm. TBR=hta@webrtc.org Bug: webrtc:11410 Change-Id: I93bf224cb52f88e8772c959de0eab81dbca261e0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/197680 Reviewed-by: Taylor Commit-Queue: Taylor Cr-Commit-Position: refs/heads/master@{#32885} --- rtc_base/boringssl_certificate.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtc_base/boringssl_certificate.cc b/rtc_base/boringssl_certificate.cc index 9be7664706..4e55cf398f 100644 --- a/rtc_base/boringssl_certificate.cc +++ b/rtc_base/boringssl_certificate.cc @@ -64,7 +64,7 @@ static const uint8_t kECDSAWithSHA256[] = {0x2a, 0x86, 0x48, 0xce, static const uint8_t kSHA256WithRSAEncryption[] = {0x2a, 0x86, 0x48, 0x86, 0xf7, 0x0d, 0x01, 0x01, 0x0b}; static const uint8_t kDSAWithSHA256[] = {0x60, 0x86, 0x48, 0x01, 0x65, - 0x03, 0x04, 0x03, 0x028}; + 0x03, 0x04, 0x03, 0x02}; static const uint8_t kECDSAWithSHA384[] = {0x2a, 0x86, 0x48, 0xce, 0x3d, 0x04, 0x03, 0x03}; static const uint8_t kSHA384WithRSAEncryption[] = {0x2a, 0x86, 0x48, 0x86, 0xf7,