admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add rtc_offer_answer_options to peer_connection_quality_test_params.

Browse Source 
And use it to generate SDP offers.

Bug: b/203195868
Change-Id: I6f04c92dcef42e2d406d954c2e2ee6e845bcbac1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258795
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36551}
This commit is contained in:
Artem Titarenko 2022-04-13 17:33:43 +02:00 committed by WebRTC LUCI CQ
parent 35c5cc8a6f
commit 21f12d592a
4 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/test/peerconnection_quality_test_fixture.h
View File

@ -431,6 +431,8 @@ class PeerConnectionE2EQualityTestFixture {
virtual PeerConfigurer* SetAecDumpPath(std::string path) = 0;
virtual PeerConfigurer* SetRTCConfiguration(
PeerConnectionInterface::RTCConfiguration configuration) = 0;
virtual PeerConfigurer* SetRTCOfferAnswerOptions(
PeerConnectionInterface::RTCOfferAnswerOptions options) = 0;
// Set bitrate parameters on PeerConnection. This constraints will be
// applied to all summed RTP streams for this peer.
virtual PeerConfigurer* SetBitrateSettings(

5
test/pc/e2e/peer_configurer.h
View File

@ -190,6 +190,11 @@ class PeerConfigurerImpl final
params_->rtc_configuration = std::move(configuration);
return this;
}
PeerConfigurer* SetRTCOfferAnswerOptions(
PeerConnectionInterface::RTCOfferAnswerOptions options) override {
params_->rtc_offer_answer_options = std::move(options);
return this;
}
PeerConfigurer* SetBitrateSettings(
BitrateSettings bitrate_settings) override {
params_->bitrate_settings = bitrate_settings;

1
test/pc/e2e/peer_connection_quality_test_params.h
View File

@ -139,6 +139,7 @@ struct Params {
double video_encoder_bitrate_multiplier = 1.0;
PeerConnectionInterface::RTCConfiguration rtc_configuration;
PeerConnectionInterface::RTCOfferAnswerOptions rtc_offer_answer_options;
BitrateSettings bitrate_settings;
std::vector<PeerConnectionE2EQualityTestFixture::VideoCodecConfig>
video_codecs;

5
test/pc/e2e/test_peer.h
View File

@ -57,12 +57,11 @@ class TestPeer final {
void CreateOffer(
rtc::scoped_refptr<CreateSessionDescriptionObserver> observer) {
RTC_CHECK(wrapper_) << "TestPeer is already closed";
pc()->CreateOffer(observer.release(),
webrtc::PeerConnectionInterface::RTCOfferAnswerOptions());
pc()->CreateOffer(observer.release(), params_->rtc_offer_answer_options);
}
std::unique_ptr<SessionDescriptionInterface> CreateOffer() {
RTC_CHECK(wrapper_) << "TestPeer is already closed";
return wrapper_->CreateOffer();
return wrapper_->CreateOffer(params_->rtc_offer_answer_options);
}
std::unique_ptr<SessionDescriptionInterface> CreateAnswer() {