admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add RTC_EXPORT to API structs needed for RTCRtpTransport JS API

Browse Source 
Bug: chromium:345101934
Change-Id: Ice0b0999c1d82dabba81187a4299deb7809dcd41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353983
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Auto-Submit: Tony Herre <herre@google.com>
Commit-Queue: Stefan Holmer <stefan@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42451}
This commit is contained in:
Tony Herre 2024-06-07 13:28:21 +02:00 committed by WebRTC LUCI CQ
parent 11e366db30
commit 21bfa5fb88
3 changed files with 23 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
api/transport/BUILD.gn
View File

@ -93,6 +93,7 @@ rtc_library("goog_cc") {
"..:network_state_predictor_api",
"../../api/units:time_delta",
"../../modules/congestion_controller/goog_cc",
"../../rtc_base/system:rtc_export",
]
}

3
api/transport/goog_cc_factory.h
View File

@ -16,6 +16,7 @@
#include "api/network_state_predictor.h"
#include "api/transport/network_control.h"
#include "api/units/time_delta.h"
#include "rtc_base/system/rtc_export.h"
namespace webrtc {
@ -26,7 +27,7 @@ struct GoogCcFactoryConfig {
bool feedback_only = false;
};
class GoogCcNetworkControllerFactory
class RTC_EXPORT GoogCcNetworkControllerFactory
: public NetworkControllerFactoryInterface {
public:
GoogCcNetworkControllerFactory() = default;

40
api/transport/network_types.h
View File

@ -27,7 +27,7 @@ namespace webrtc {
// Represents constraints and rates related to the currently enabled streams.
// This is used as input to the congestion controller via the StreamsConfig
// struct.
struct BitrateAllocationLimits {
struct RTC_EXPORT BitrateAllocationLimits {
// The total minimum send bitrate required by all sending streams.
DataRate min_allocatable_rate = DataRate::Zero();
// The total maximum allocatable bitrate for all currently available streams.
@ -40,7 +40,7 @@ struct BitrateAllocationLimits {
// Use StreamsConfig for information about streams that is required for specific
// adjustments to the algorithms in network controllers. Especially useful
// for experiments.
struct StreamsConfig {
struct RTC_EXPORT StreamsConfig {
StreamsConfig();
StreamsConfig(const StreamsConfig&);
~StreamsConfig();
@ -58,7 +58,7 @@ struct StreamsConfig {
absl::optional<DataRate> max_total_allocated_bitrate;
};
struct TargetRateConstraints {
struct RTC_EXPORT TargetRateConstraints {
TargetRateConstraints();
TargetRateConstraints(const TargetRateConstraints&);
~TargetRateConstraints();
@ -72,12 +72,12 @@ struct TargetRateConstraints {
// Send side information
struct NetworkAvailability {
struct RTC_EXPORT NetworkAvailability {
Timestamp at_time = Timestamp::PlusInfinity();
bool network_available = false;
};
struct NetworkRouteChange {
struct RTC_EXPORT NetworkRouteChange {
NetworkRouteChange();
NetworkRouteChange(const NetworkRouteChange&);
~NetworkRouteChange();
@ -87,7 +87,7 @@ struct NetworkRouteChange {
TargetRateConstraints constraints;
};
struct PacedPacketInfo {
struct RTC_EXPORT PacedPacketInfo {
PacedPacketInfo();
PacedPacketInfo(int probe_cluster_id,
int probe_cluster_min_probes,
@ -104,7 +104,7 @@ struct PacedPacketInfo {
int probe_cluster_bytes_sent = 0;
};
struct SentPacket {
struct RTC_EXPORT SentPacket {
Timestamp send_time = Timestamp::PlusInfinity();
// Size of packet with overhead up to IP layer.
DataSize size = DataSize::Zero();
@ -123,7 +123,7 @@ struct SentPacket {
DataSize data_in_flight = DataSize::Zero();
};
struct ReceivedPacket {
struct RTC_EXPORT ReceivedPacket {
Timestamp send_time = Timestamp::MinusInfinity();
Timestamp receive_time = Timestamp::PlusInfinity();
DataSize size = DataSize::Zero();
@ -131,18 +131,18 @@ struct ReceivedPacket {
// Transport level feedback
struct RemoteBitrateReport {
struct RTC_EXPORT RemoteBitrateReport {
Timestamp receive_time = Timestamp::PlusInfinity();
DataRate bandwidth = DataRate::Infinity();
};
struct RoundTripTimeUpdate {
struct RTC_EXPORT RoundTripTimeUpdate {
Timestamp receive_time = Timestamp::PlusInfinity();
TimeDelta round_trip_time = TimeDelta::PlusInfinity();
bool smoothed = false;
};
struct TransportLossReport {
struct RTC_EXPORT TransportLossReport {
Timestamp receive_time = Timestamp::PlusInfinity();
Timestamp start_time = Timestamp::PlusInfinity();
Timestamp end_time = Timestamp::PlusInfinity();
@ -152,7 +152,7 @@ struct TransportLossReport {
// Packet level feedback
struct PacketResult {
struct RTC_EXPORT PacketResult {
class ReceiveTimeOrder {
public:
bool operator()(const PacketResult& lhs, const PacketResult& rhs);
@ -168,7 +168,7 @@ struct PacketResult {
Timestamp receive_time = Timestamp::PlusInfinity();
};
struct TransportPacketsFeedback {
struct RTC_EXPORT TransportPacketsFeedback {
TransportPacketsFeedback();
TransportPacketsFeedback(const TransportPacketsFeedback& other);
~TransportPacketsFeedback();
@ -188,7 +188,7 @@ struct TransportPacketsFeedback {
// Network estimation
struct NetworkEstimate {
struct RTC_EXPORT NetworkEstimate {
Timestamp at_time = Timestamp::PlusInfinity();
// Deprecated, use TargetTransferRate::target_rate instead.
DataRate bandwidth = DataRate::Infinity();
@ -200,7 +200,7 @@ struct NetworkEstimate {
// Network control
struct PacerConfig {
struct RTC_EXPORT PacerConfig {
Timestamp at_time = Timestamp::PlusInfinity();
// Pacer should send at most data_window data over time_window duration.
DataSize data_window = DataSize::Infinity();
@ -211,7 +211,7 @@ struct PacerConfig {
DataRate pad_rate() const { return pad_window / time_window; }
};
struct ProbeClusterConfig {
struct RTC_EXPORT ProbeClusterConfig {
Timestamp at_time = Timestamp::PlusInfinity();
DataRate target_data_rate = DataRate::Zero();
// Duration of a probe.
@ -222,7 +222,7 @@ struct ProbeClusterConfig {
int32_t id = 0;
};
struct TargetTransferRate {
struct RTC_EXPORT TargetTransferRate {
Timestamp at_time = Timestamp::PlusInfinity();
// The estimate on which the target rate is based on.
NetworkEstimate network_estimate;
@ -234,7 +234,7 @@ struct TargetTransferRate {
// Contains updates of network controller comand state. Using optionals to
// indicate whether a member has been updated. The array of probe clusters
// should be used to send out probes if not empty.
struct NetworkControlUpdate {
struct RTC_EXPORT NetworkControlUpdate {
NetworkControlUpdate();
NetworkControlUpdate(const NetworkControlUpdate&);
~NetworkControlUpdate();
@ -251,13 +251,13 @@ struct NetworkControlUpdate {
};
// Process control
struct ProcessInterval {
struct RTC_EXPORT ProcessInterval {
Timestamp at_time = Timestamp::PlusInfinity();
absl::optional<DataSize> pacer_queue;
};
// Under development, subject to change without notice.
struct NetworkStateEstimate {
struct RTC_EXPORT NetworkStateEstimate {
double confidence = NAN;
// The time the estimate was received/calculated.
Timestamp update_time = Timestamp::MinusInfinity();