From 20fcbf15f063d43acc3ad3d4c5134b92644dc13f Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Wed, 31 Aug 2016 18:47:16 +0200 Subject: [PATCH] Remove faulty DCHECK in rtcp::TransportFeedback DecodeSymbol BUG=chromium:642745 R=sprang@webrtc.org Review URL: https://codereview.webrtc.org/2296953003 . Cr-Commit-Position: refs/heads/master@{#14003} --- .../modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc index cce0075ade..a4f0f6bbdc 100644 --- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc +++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc @@ -60,7 +60,11 @@ TransportFeedback::StatusSymbol DecodeSymbol(uint8_t value) { return TransportFeedback::StatusSymbol::kReceivedSmallDelta; case 2: return TransportFeedback::StatusSymbol::kReceivedLargeDelta; + case 3: + // It is invalid, but |value| comes from network, so can be any. + return TransportFeedback::StatusSymbol::kNotReceived; default: + // Caller should pass 2 bits max. RTC_NOTREACHED(); return TransportFeedback::StatusSymbol::kNotReceived; }