From 20a05cd778affe554fc372e4903532b707c16502 Mon Sep 17 00:00:00 2001
From: "leozwang@webrtc.org"
 <leozwang@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d>
Date: Mon, 7 May 2012 21:16:33 +0000
Subject: [PATCH] Disable WEBRTC_SVNREVISION

Description:
This CL will temporally define WEBRTC_SVNREVISION as "n/a" because it
could break Chromium if svn is not installed.
The long term solution is a have a script that could deal with it, and
have it support git-svn which is used by most developers.

BUG=496
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/569007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2187 4adac7df-926f-26a2-2b94-8c16560cd09d
---
 src/build/common.gypi | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/build/common.gypi b/src/build/common.gypi
index 8a63796557..d161b0cdf8 100644
--- a/src/build/common.gypi
+++ b/src/build/common.gypi
@@ -91,9 +91,16 @@
       '..','../..', # common_types.h, typedefs.h
     ],
     'defines': [
-      # TODO(leozwang): Most of team use git-svn, need to add
-      # git-svn support as well.
-      'WEBRTC_SVNREVISION="<!(svnversion -n)"',
+      # TODO(leozwang): Temporally disable it because we cannot assume svn
+      # is installed by default, it will break Chromium build. The problem
+      # could happen on Gentoo which download and build tar ball directly,
+      # it also could happen when developer downloads Chromium tar ball and
+      # build inside source tree without svn installed. The solution is to
+      # have a script to deal with these cases and support git-svn.
+      # Two similar issues have been filed at
+      # WebRTC http://code.google.com/p/webrtc/issues/detail?id=496
+      # Chromium http://code.google.com/p/chromium/issues/detail?id=126452
+      'WEBRTC_SVNREVISION="n/a"',
     ],
     'conditions': [
       ['build_with_chromium==1', {