admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Don't call EXPECT_TRUE_WAIT recursively."

Browse Source 
This reverts commit d0dfe95bf082df7c38b24c8d20da91339f5199e5.

Reason for revert: It didn't help

Original change's description:
> Don't call EXPECT_TRUE_WAIT recursively.
>
> In case this triggers unexpected error handling on ASAN.
>
> Bug: webrtc:15018
> Change-Id: Iec8154081f3831ee60902bb94900d79a98ea01fa
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300480
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#39779}

Bug: webrtc:15018
Change-Id: I3b6e2434e2c88719ebf9f32c9d9a4dd1c21178a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300482
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39781}
This commit is contained in:
Henrik Boström 2023-04-06 11:29:55 +00:00 committed by WebRTC LUCI CQ
parent ba5f633a94
commit 209a448307
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pc/peer_connection_simulcast_unittest.cc
View File

@ -986,10 +986,7 @@ class PeerConnectionSimulcastWithMediaFlowTests
rtc::scoped_refptr<PeerConnectionTestWrapper> pc_wrapper) {
auto callback = rtc::make_ref_counted<MockRTCStatsCollectorCallback>();
pc_wrapper->pc()->GetStats(callback.get());
while (!callback->called()) {
rtc::Thread::Current()->ProcessMessages(0);
rtc::Thread::Current()->SleepMs(1);
}
EXPECT_TRUE_WAIT(callback->called(), kDefaultTimeout.ms());
return callback->report();
}