From 1f5e98d97eca1b557d6299c87ec6642ba8b0ac46 Mon Sep 17 00:00:00 2001 From: Taylor Brandstetter Date: Fri, 26 Jan 2018 12:20:27 -0800 Subject: [PATCH] Increasing "SERVER_WAIT" for TCPChannelClient tests. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is the time to wait after creating the server to ensure it's listening before trying to connect to it. The previous value of 10 was not enough; tests occasionally failed. Bug: webrtc:8711 Change-Id: I67d592fdb9a863d574f2a33096b7050935693f4e Reviewed-on: https://webrtc-review.googlesource.com/44521 Reviewed-by: Kári Helgason Commit-Queue: Taylor Brandstetter Cr-Commit-Position: refs/heads/master@{#21793} --- .../src/org/appspot/apprtc/TCPChannelClientTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java b/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java index 0f4916aa48..8c5f38ccb3 100644 --- a/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java +++ b/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java @@ -35,10 +35,10 @@ import java.util.concurrent.TimeUnit; public class TCPChannelClientTest { private static final int PORT = 8888; /** - * How long we wait before trying to connect to the server. Chosen quite arbitrarily and - * could be made smaller if need be. + * How long we wait before trying to connect to the server. Note: was + * previously only 10, which was too short (tests were flaky). */ - private static final int SERVER_WAIT = 10; + private static final int SERVER_WAIT = 100; private static final int CONNECT_TIMEOUT = 100; private static final int SEND_TIMEOUT = 100; private static final int DISCONNECT_TIMEOUT = 100;