From 1ebd2e96df5b6d1c30d18b3ce8b928f99666c53f Mon Sep 17 00:00:00 2001 From: "turaj@webrtc.org" Date: Fri, 25 Jul 2014 17:50:10 +0000 Subject: [PATCH] Remove timestamp retreival warning/error. An error reported while retreiving playout timestamp if no RTP packet received, yet. This causes an overflow of errors/warnings in applications where few channel are created but only one is actively engaged in a conversation. Therefore, we don't find such logging informative (there is no check upon correctness of timestamp computaion only if a packet already received). BUG=3545 TEST=manual with voe_cmd_test,try bots R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/18869004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6781 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/voice_engine/channel.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc index af773e7704..e811a273de 100644 --- a/webrtc/voice_engine/channel.cc +++ b/webrtc/voice_engine/channel.cc @@ -4025,12 +4025,8 @@ void Channel::UpdatePlayoutTimestamp(bool rtcp) { uint32_t playout_timestamp = 0; if (audio_coding_->PlayoutTimestamp(&playout_timestamp) == -1) { - WEBRTC_TRACE(kTraceWarning, kTraceVoice, VoEId(_instanceId,_channelId), - "Channel::UpdatePlayoutTimestamp() failed to read playout" - " timestamp from the ACM"); - _engineStatisticsPtr->SetLastError( - VE_CANNOT_RETRIEVE_VALUE, kTraceError, - "UpdatePlayoutTimestamp() failed to retrieve timestamp"); + // This can happen if this channel has not been received any RTP packet. In + // this case, NetEq is not capable of computing playout timestamp. return; }