admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete VideoCodec::targetBitrate

Browse Source 
This member is unused by encoders.

Bug: None
Change-Id: I867013bfdb89f48782e84842de05bb57648e0b64
Reviewed-on: https://webrtc-review.googlesource.com/c/113882
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25988}
This commit is contained in:
Niels Möller 2018-12-11 13:13:36 +01:00 committed by Commit Bot
parent ab64e8a7ea
commit 1d8307d706
8 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
api/video_codecs/video_codec.cc
View File

@ -66,7 +66,6 @@ VideoCodec::VideoCodec()
startBitrate(0), startBitrate(0),
maxBitrate(0), maxBitrate(0),
minBitrate(0), minBitrate(0),
targetBitrate(0),
maxFramerate(0), maxFramerate(0),
active(true), active(true),
qpMax(0), qpMax(0),

1
api/video_codecs/video_codec.h
View File

@ -118,7 +118,6 @@ class RTC_EXPORT VideoCodec {
unsigned int startBitrate; // kilobits/sec. unsigned int startBitrate; // kilobits/sec.
unsigned int maxBitrate; // kilobits/sec. unsigned int maxBitrate; // kilobits/sec.
unsigned int minBitrate; // kilobits/sec. unsigned int minBitrate; // kilobits/sec.
unsigned int targetBitrate; // kilobits/sec.
uint32_t maxFramerate; uint32_t maxFramerate;

1
media/engine/simulcast_encoder_adapter_unittest.cc
View File

@ -679,7 +679,6 @@ TEST_F(TestSimulcastEncoderAdapterFake, ReinitDoesNotReorderEncoderSettings) {
EXPECT_EQ(codec_before.startBitrate, codec_after.startBitrate); EXPECT_EQ(codec_before.startBitrate, codec_after.startBitrate);
EXPECT_EQ(codec_before.maxBitrate, codec_after.maxBitrate); EXPECT_EQ(codec_before.maxBitrate, codec_after.maxBitrate);
EXPECT_EQ(codec_before.minBitrate, codec_after.minBitrate); EXPECT_EQ(codec_before.minBitrate, codec_after.minBitrate);
EXPECT_EQ(codec_before.targetBitrate, codec_after.targetBitrate);
EXPECT_EQ(codec_before.maxFramerate, codec_after.maxFramerate); EXPECT_EQ(codec_before.maxFramerate, codec_after.maxFramerate);
EXPECT_EQ(codec_before.qpMax, codec_after.qpMax); EXPECT_EQ(codec_before.qpMax, codec_after.qpMax);
EXPECT_EQ(codec_before.numberOfSimulcastStreams, EXPECT_EQ(codec_before.numberOfSimulcastStreams,

1
modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
View File

@ -400,7 +400,6 @@ TEST_F(TestVp8Impl, KeepsTimestampOnReencode) {
// Settings needed to trigger ScreenshareLayers usage, which is required for // Settings needed to trigger ScreenshareLayers usage, which is required for
// overshoot-drop-reencode logic. // overshoot-drop-reencode logic.
codec_settings_.targetBitrate = 200;
codec_settings_.maxBitrate = 1000; codec_settings_.maxBitrate = 1000;
codec_settings_.mode = VideoCodecMode::kScreensharing; codec_settings_.mode = VideoCodecMode::kScreensharing;
codec_settings_.VP8()->numberOfTemporalLayers = 2; codec_settings_.VP8()->numberOfTemporalLayers = 2;

2
sdk/objc/api/peerconnection/RTCVideoEncoderSettings+Private.mm
View File

@ -25,7 +25,6 @@
self.startBitrate = videoCodec->startBitrate; self.startBitrate = videoCodec->startBitrate;
self.maxBitrate = videoCodec->maxBitrate; self.maxBitrate = videoCodec->maxBitrate;
self.minBitrate = videoCodec->minBitrate; self.minBitrate = videoCodec->minBitrate;
self.targetBitrate = videoCodec->targetBitrate;
self.maxFramerate = videoCodec->maxFramerate; self.maxFramerate = videoCodec->maxFramerate;
self.qpMax = videoCodec->qpMax; self.qpMax = videoCodec->qpMax;
self.mode = (RTCVideoCodecMode)videoCodec->mode; self.mode = (RTCVideoCodecMode)videoCodec->mode;
@ -42,7 +41,6 @@
videoCodec.startBitrate = self.startBitrate; videoCodec.startBitrate = self.startBitrate;
videoCodec.maxBitrate = self.maxBitrate; videoCodec.maxBitrate = self.maxBitrate;
videoCodec.minBitrate = self.minBitrate; videoCodec.minBitrate = self.minBitrate;
videoCodec.targetBitrate = self.targetBitrate;
videoCodec.maxBitrate = self.maxBitrate; videoCodec.maxBitrate = self.maxBitrate;
videoCodec.qpMax = self.qpMax; videoCodec.qpMax = self.qpMax;
videoCodec.mode = (webrtc::VideoCodecMode)self.mode; videoCodec.mode = (webrtc::VideoCodecMode)self.mode;

1
sdk/objc/base/RTCVideoEncoderSettings.h
View File

@ -31,7 +31,6 @@ RTC_OBJC_EXPORT
@property(nonatomic, assign) unsigned int startBitrate; // kilobits/sec. @property(nonatomic, assign) unsigned int startBitrate; // kilobits/sec.
@property(nonatomic, assign) unsigned int maxBitrate; @property(nonatomic, assign) unsigned int maxBitrate;
@property(nonatomic, assign) unsigned int minBitrate; @property(nonatomic, assign) unsigned int minBitrate;
@property(nonatomic, assign) unsigned int targetBitrate;
@property(nonatomic, assign) uint32_t maxFramerate; @property(nonatomic, assign) uint32_t maxFramerate;

1
sdk/objc/base/RTCVideoEncoderSettings.m
View File

@ -18,7 +18,6 @@
@synthesize startBitrate = _startBitrate; @synthesize startBitrate = _startBitrate;
@synthesize maxBitrate = _maxBitrate; @synthesize maxBitrate = _maxBitrate;
@synthesize minBitrate = _minBitrate; @synthesize minBitrate = _minBitrate;
@synthesize targetBitrate = _targetBitrate;
@synthesize maxFramerate = _maxFramerate; @synthesize maxFramerate = _maxFramerate;
@synthesize qpMax = _qpMax; @synthesize qpMax = _qpMax;
@synthesize mode = _mode; @synthesize mode = _mode;

1
test/video_codec_settings.h
View File

@ -35,7 +35,6 @@ static void CodecSettings(VideoCodecType codec_type, VideoCodec* settings) {
settings->startBitrate = kTestStartBitrateKbps; settings->startBitrate = kTestStartBitrateKbps;
settings->maxBitrate = 0; settings->maxBitrate = 0;
settings->minBitrate = kTestMinBitrateKbps; settings->minBitrate = kTestMinBitrateKbps;
settings->targetBitrate = 0;
settings->maxFramerate = kTestFrameRate; settings->maxFramerate = kTestFrameRate;