From 1d732434669202caac26db4af31d3dd6927cfdd4 Mon Sep 17 00:00:00 2001 From: Tim Na Date: Tue, 9 Nov 2021 11:54:29 -0800 Subject: [PATCH] Use a new instance of RTP stack for each test. - Reusing RTP stack may have contributed to some flakiness as the previous state could have persisted to new test being performed. Bug: webrtc:13241 Change-Id: Idf70b56bd3377bc99321fddf7191d7a72c37b085 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237540 Reviewed-by: Gustaf Ullberg Commit-Queue: Tim Na Cr-Commit-Position: refs/heads/main@{#35336} --- audio/voip/test/audio_egress_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/audio/voip/test/audio_egress_unittest.cc b/audio/voip/test/audio_egress_unittest.cc index 0692ef2df4..d114253c15 100644 --- a/audio/voip/test/audio_egress_unittest.cc +++ b/audio/voip/test/audio_egress_unittest.cc @@ -57,7 +57,6 @@ class AudioEgressTest : public ::testing::Test { AudioEgressTest() : fake_clock_(kStartTime), wave_generator_(1000.0, kAudioLevel) { - rtp_rtcp_ = CreateRtpStack(&fake_clock_, &transport_, kRemoteSsrc); task_queue_factory_ = CreateDefaultTaskQueueFactory(); encoder_factory_ = CreateBuiltinAudioEncoderFactory(); } @@ -65,6 +64,7 @@ class AudioEgressTest : public ::testing::Test { // Prepare test on audio egress by using PCMu codec with specific // sequence number and its status to be running. void SetUp() override { + rtp_rtcp_ = CreateRtpStack(&fake_clock_, &transport_, kRemoteSsrc); egress_ = std::make_unique(rtp_rtcp_.get(), &fake_clock_, task_queue_factory_.get()); constexpr int kPcmuPayload = 0; @@ -81,6 +81,7 @@ class AudioEgressTest : public ::testing::Test { egress_->StopSend(); rtp_rtcp_->SetSendingStatus(false); egress_.reset(); + rtp_rtcp_.reset(); } // Create an audio frame prepared for pcmu encoding. Timestamp is