From 1d4830a077f6cd3a0fd1d062a93a244118b83e9b Mon Sep 17 00:00:00 2001 From: "tommi@webrtc.org" Date: Sat, 7 Feb 2015 08:44:28 +0000 Subject: [PATCH] Disable ProcessThread tests that are dependent on timing. Some of the bots are too slow for the tests to make much sense as they are. TBR=bjornv@webrtc.org Review URL: https://webrtc-codereview.appspot.com/39869004 Cr-Commit-Position: refs/heads/master@{#8281} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8281 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../source/process_thread_impl_unittest.cc | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/webrtc/modules/utility/source/process_thread_impl_unittest.cc b/webrtc/modules/utility/source/process_thread_impl_unittest.cc index c61eae9bce..a45d5b24f9 100644 --- a/webrtc/modules/utility/source/process_thread_impl_unittest.cc +++ b/webrtc/modules/utility/source/process_thread_impl_unittest.cc @@ -160,15 +160,21 @@ void ProcessCallAfterAFewMs(int64_t milliseconds) { EXPECT_LT(diff, milliseconds + 15); } -TEST(ProcessThreadImpl, ProcessCallAfter5ms) { +// DISABLED for now since the virtual build bots are too slow :( +// TODO(tommi): Fix. +TEST(ProcessThreadImpl, DISABLED_ProcessCallAfter5ms) { ProcessCallAfterAFewMs(5); } -TEST(ProcessThreadImpl, ProcessCallAfter50ms) { +// DISABLED for now since the virtual build bots are too slow :( +// TODO(tommi): Fix. +TEST(ProcessThreadImpl, DISABLED_ProcessCallAfter50ms) { ProcessCallAfterAFewMs(50); } -TEST(ProcessThreadImpl, ProcessCallAfter200ms) { +// DISABLED for now since the virtual build bots are too slow :( +// TODO(tommi): Fix. +TEST(ProcessThreadImpl, DISABLED_ProcessCallAfter200ms) { ProcessCallAfterAFewMs(200); } @@ -176,7 +182,10 @@ TEST(ProcessThreadImpl, ProcessCallAfter200ms) { // (on average 1 callback every 20ms). On real hardware, we're usually pretty // close to that, but the test bots that run on virtual machines, will // typically be in the range 30-40 callbacks. -TEST(ProcessThreadImpl, MANUAL_Process50Times) { +// DISABLED for now since this can take up to 2 seconds to run on the slowest +// build bots. +// TODO(tommi): Fix. +TEST(ProcessThreadImpl, DISABLED_Process50Times) { ProcessThreadImpl thread; ASSERT_EQ(0, thread.Start());