admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused killswitch flag related to scalability mode.

Browse Source 
In M113 we made it possible to opt-in to spec-compliant VP9 using
scalabilityMode and scaleResolutionDownBy. Since this would change
behavior in some edge cases a kill-switch flag was also added.

It turns out it was not needed (current Stable: M114) so we can remove
the flag.

Bug: webrtc:14884
Change-Id: Ie3006164c4d6e90acad1d1f4df2fe2b6e3cb2c35
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308683
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40277}
This commit is contained in:
Henrik Boström 2023-06-14 12:00:55 +02:00 committed by WebRTC LUCI CQ
parent 49ace8b654
commit 1cb54bee7a
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
media/engine/webrtc_video_engine.cc
View File

@ -2736,16 +2736,12 @@ WebRtcVideoSendChannel::WebRtcVideoSendStream::CreateVideoEncoderConfig(
// `legacy_scalability_mode` and codec used.
encoder_config.number_of_streams = parameters_.config.rtp.ssrcs.size();
bool legacy_scalability_mode = true;
// TODO(https://crbug.com/webrtc/14884): This is only used as a kill-switch
// in case of serious bugs - when this reaches Stable, delete the field trial.
if (!call_->trials().IsDisabled("WebRTC-AllowDisablingLegacyScalability")) {
for (const webrtc::RtpEncodingParameters& encoding :
rtp_parameters_.encodings) {
if (encoding.scalability_mode.has_value() &&
encoding.scale_resolution_down_by.has_value()) {
legacy_scalability_mode = false;
break;
}
for (const webrtc::RtpEncodingParameters& encoding :
rtp_parameters_.encodings) {
if (encoding.scalability_mode.has_value() &&
encoding.scale_resolution_down_by.has_value()) {
legacy_scalability_mode = false;
break;
}
}
// Maybe limit the number of simulcast layers depending on