admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow setting ALR values for screen content again

Browse Source 
When ALR was made default-on we removed the ability to use field trials
to configure alternative ALR detector values. This CL just restores
the ability to force them, defaults are unaffected.

Bug: webrtc:10509
Change-Id: Ibc09e27f1f7b72513de1482d280683802e962497
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131145
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27442}
This commit is contained in:
Erik Språng 2019-04-03 20:20:42 +02:00
parent 5982d008a8
commit 1c1b1ea137
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
rtc_base/experiments/alr_experiment.cc
View File

@ -44,17 +44,16 @@ AlrExperimentSettings::CreateFromFieldTrial(const char* experiment_name) {
group_name.resize(group_name.length() - kIgnoredSuffix.length());
}
if (experiment_name == kScreenshareProbingBweExperimentName) {
// This experiment is now default-on with fixed settings.
// TODO(sprang): Remove this kill-switch and clean up experiment code.
if (group_name != "Disabled") {
if (group_name.empty()) {
if (experiment_name == kScreenshareProbingBweExperimentName) {
// This experiment is now default-on with fixed settings.
// TODO(sprang): Remove this kill-switch and clean up experiment code.
group_name = kDefaultProbingScreenshareBweSettings;
} else {
return ret;
}
}
if (group_name.empty())
return ret;
AlrExperimentSettings settings;
if (sscanf(group_name.c_str(), "%f,%" PRId64 ",%d,%d,%d,%d",
&settings.pacing_factor, &settings.max_paced_queue_time,