From 1b31c78e5f1be27c5f22a02f78f727ccb180a135 Mon Sep 17 00:00:00 2001 From: "andrew@webrtc.org" Date: Tue, 26 Mar 2013 14:09:48 +0000 Subject: [PATCH] Remove VoE's default call in Trace::SetLevelFilter. This is an application level setting. Applying it here has the potential to override the application's preferences. BUG= Review URL: https://webrtc-codereview.appspot.com/1252004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@3727 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/voice_engine/shared_data.cc | 1 - webrtc/voice_engine/voice_engine_defines.h | 8 -------- 2 files changed, 9 deletions(-) diff --git a/webrtc/voice_engine/shared_data.cc b/webrtc/voice_engine/shared_data.cc index 0426ecaa4e..69ac8570b2 100644 --- a/webrtc/voice_engine/shared_data.cc +++ b/webrtc/voice_engine/shared_data.cc @@ -35,7 +35,6 @@ SharedData::SharedData() : _externalPlayout(false) { Trace::CreateTrace(); - Trace::SetLevelFilter(WEBRTC_VOICE_ENGINE_DEFAULT_TRACE_FILTER); if (OutputMixer::Create(_outputMixerPtr, _gInstanceCounter) == 0) { _outputMixerPtr->SetEngineInformation(_engineStatistics); diff --git a/webrtc/voice_engine/voice_engine_defines.h b/webrtc/voice_engine/voice_engine_defines.h index e5c9af9dce..ba9f8ce180 100644 --- a/webrtc/voice_engine/voice_engine_defines.h +++ b/webrtc/voice_engine/voice_engine_defines.h @@ -207,14 +207,6 @@ enum { kVoiceEngineMaxRtpExtensionId = 14 }; #define CHECK_CHANNEL(channel) if (CheckChannel(channel) == -1) return -1; -// ---------------------------------------------------------------------------- -// Default Trace filter -// ---------------------------------------------------------------------------- - -#define WEBRTC_VOICE_ENGINE_DEFAULT_TRACE_FILTER \ - kTraceStateInfo | kTraceWarning | kTraceError | kTraceCritical | \ - kTraceApiCall - // ---------------------------------------------------------------------------- // Inline functions // ----------------------------------------------------------------------------