From 18b823e0f5732f0ce6db76f3db7e37b4fa7847c7 Mon Sep 17 00:00:00 2001 From: Edward Lemur Date: Fri, 24 Nov 2017 18:38:31 +0000 Subject: [PATCH] Revert "Let PrintResultMeanAndError accept a string." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit b54bc06079a66a379595068f6ea56d56a4fd95c0. Reason for revert: Downstream projects should be fixed now Original change's description: > Let PrintResultMeanAndError accept a string. > > Some downstream projects still use it. I'll update them and then revert > this change. > > Bug: webrtc:8566 > Change-Id: Ib4e56348c40a3645f3049382b47089ca6c675e96 > Reviewed-on: https://webrtc-review.googlesource.com/25841 > Commit-Queue: Edward Lemur > Reviewed-by: Patrik Höglund > Cr-Commit-Position: refs/heads/master@{#20872} TBR=phoglund@webrtc.org,ehmaldonado@webrtc.org Change-Id: I5d2a59cbfb6a148fc6c621a69fa23397ba2c6991 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:8566 Reviewed-on: https://webrtc-review.googlesource.com/25920 Reviewed-by: Edward Lemur Commit-Queue: Edward Lemur Cr-Commit-Position: refs/heads/master@{#20880} --- test/testsupport/perf_test.cc | 10 ---------- test/testsupport/perf_test.h | 7 ------- 2 files changed, 17 deletions(-) diff --git a/test/testsupport/perf_test.cc b/test/testsupport/perf_test.cc index cf244df765..bb4491af91 100644 --- a/test/testsupport/perf_test.cc +++ b/test/testsupport/perf_test.cc @@ -85,16 +85,6 @@ void PrintResultMeanAndError(const std::string& measurement, units, important); } -void PrintResultMeanAndError(const std::string& measurement, - const std::string& modifier, - const std::string& trace, - const std::string& mean_and_error, - const std::string& units, - bool important) { - PrintResultsImpl(measurement, modifier, trace, mean_and_error, "{", "}", - units, important); -} - void PrintResultList(const std::string& measurement, const std::string& modifier, const std::string& trace, diff --git a/test/testsupport/perf_test.h b/test/testsupport/perf_test.h index 2c98b8ec0a..02dd1f3713 100644 --- a/test/testsupport/perf_test.h +++ b/test/testsupport/perf_test.h @@ -52,13 +52,6 @@ void PrintResultMeanAndError(const std::string& measurement, const std::string& units, bool important); -void PrintResultMeanAndError(const std::string& measurement, - const std::string& modifier, - const std::string& trace, - const std::string& mean_and_error, - const std::string& units, - bool important); - // Like PrintResult(), but prints an entire list of results. The |values| // will generally be a list of comma-separated numbers. A typical // post-processing step might produce plots of their mean and standard