From 185910953ae50c474c5f27d0eaefe48cfa46ae59 Mon Sep 17 00:00:00 2001 From: Emil Vardar Date: Thu, 12 Sep 2024 11:44:37 +0000 Subject: [PATCH] Specify in which RTP packet corruption score will be sent on. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See e.g. this: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc;l=304;bpv=1;bpt=0?q=webrtc%2Fmodules%2Frtp_rtcp%2Fsource%2Frtp_sender_video.cc&ss=chromium%2Fchromium%2Fsrc:third_party%2Fwebrtc%2F. One needs to know if the extension will be added to the first or last packet. Furthermore, one can see that other extensions add it as a note at the bottom, which I follow here. See e.g. http://www.webrtc.org/experiments/rtp-hdrext/video-content-type Bug: webrtc:358039777 Change-Id: I7523f5e6b267528a1389bcbde6ee6fa22fb3233a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362060 Reviewed-by: Erik Språng Reviewed-by: Fanny Linderborg Commit-Queue: Emil Vardar (xWF) Cr-Commit-Position: refs/heads/main@{#43013} --- docs/native-code/rtp-hdrext/corruption-detection/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/native-code/rtp-hdrext/corruption-detection/README.md b/docs/native-code/rtp-hdrext/corruption-detection/README.md index 50dc779526..0265c9a76a 100644 --- a/docs/native-code/rtp-hdrext/corruption-detection/README.md +++ b/docs/native-code/rtp-hdrext/corruption-detection/README.md @@ -350,3 +350,5 @@ Regardless of method, the implementation at the send side SHOULD strive to set the filter size and error thresholds such that 99.5% of filtered samples end up with a delta <= the error threshold for that plane, based on a representative set of test clips and bandwidth constraints. + +Notes: The extension must not be present in more than 1 packet per video frame.