admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make GetSourcesVideo test wait for two frames

Browse Source 
When it waits for only one frame, the test is flaky.
When it waits for two frames, it is not.

# Relying on triviality for confidence due to purple bots atm,
# see b/367211396
NOTRY=True
NOPRESUBMIT=True

Bug: webrtc:367205682, webrtc:42220900
Change-Id: I14963b7a86961f438fd511aba8f29525e1f19750
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362583
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43025}
This commit is contained in:
Harald Alvestrand 2024-09-16 11:26:38 +00:00 committed by WebRTC LUCI CQ
parent cbf5122333
commit 18486c5574
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pc/peer_connection_integrationtest.cc
View File

@ -2637,9 +2637,10 @@ TEST_P(PeerConnectionIntegrationTest, GetSourcesVideo) {
caller()->AddVideoTrack();
caller()->CreateAndSetAndSignalOffer();
ASSERT_TRUE_WAIT(SignalingStateStable(), kDefaultTimeout);
// Wait for one video frame to be received by the callee.
// Wait for two video frames to be received by the callee.
// TODO: https://issues.webrtc.org/42220900 - wait for only one frame again
MediaExpectations media_expectations;
media_expectations.CalleeExpectsSomeVideo(1);
media_expectations.CalleeExpectsSomeVideo(2);
ASSERT_TRUE(ExpectNewFrames(media_expectations));
ASSERT_EQ(callee()->pc()->GetReceivers().size(), 1u);
auto receiver = callee()->pc()->GetReceivers()[0];