From 17f82cfc6870110542719f90a378002c8ca9bb28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Wed, 4 Dec 2019 11:10:43 +0100 Subject: [PATCH] Verifies trials are populated when creating a Call. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This check just makes it more clear what the expectations are. Pululating trials was made mandatory in an earlier CL, but if you don't populate this field it will trigger a DCHECK at lower layer where we're actually trying to parse an experiment. That is confusing and misleading. Bug: None Change-Id: I1f520841a5a3b911048c8ee6d309eb7bb179e037 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161301 Reviewed-by: Sebastian Jansson Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/master@{#30005} --- call/call.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/call/call.cc b/call/call.cc index 06ccd00550..967836022a 100644 --- a/call/call.cc +++ b/call/call.cc @@ -465,6 +465,7 @@ Call::Call(Clock* clock, transport_send_ptr_(transport_send.get()), transport_send_(std::move(transport_send)) { RTC_DCHECK(config.event_log != nullptr); + RTC_DCHECK(config.trials != nullptr); worker_sequence_checker_.Detach(); call_stats_->RegisterStatsObserver(&receive_side_cc_);