admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PipeWire camera: use length of device id instead display name

Browse Source 
We want to copy device id to _lastUsedDeviceName variable, but we use
length of display name instead of length of device id, which might be
longer than expected and we end up reading beyond the source string.

Bug: webrtc:15853
Change-Id: Id278ed7e361ead85475910adec18b9db51e6890b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341521
Commit-Queue: Jan Grulich <grulja@gmail.com>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41844}
This commit is contained in:
Jan Grulich 2024-02-28 21:08:16 +01:00 committed by WebRTC LUCI CQ
parent 20a90295fc
commit 16ac10d9f7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/video_capture/linux/device_info_pipewire.cc
View File

@ -94,7 +94,7 @@ int32_t DeviceInfoPipeWire::CreateCapabilityMap(
continue;
_captureCapabilities = node.capabilities();
_lastUsedDeviceNameLength = node.display_name().length();
_lastUsedDeviceNameLength = node.unique_id().length();
_lastUsedDeviceName = static_cast<char*>(
realloc(_lastUsedDeviceName, _lastUsedDeviceNameLength + 1));
memcpy(_lastUsedDeviceName, deviceUniqueIdUTF8,