From 16946e3781ec30d23071b7c4a1484942642b46a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Wed, 28 Aug 2019 10:49:08 +0200 Subject: [PATCH] Remove unused StorageType enum MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:10633 Change-Id: I65e1807c2e0419a51cd7274f85559d653c75046d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150644 Reviewed-by: Ilya Nikolaevskiy Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/master@{#29003} --- modules/rtp_rtcp/include/rtp_rtcp_defines.h | 3 --- modules/rtp_rtcp/source/rtp_sender.h | 9 --------- 2 files changed, 12 deletions(-) diff --git a/modules/rtp_rtcp/include/rtp_rtcp_defines.h b/modules/rtp_rtcp/include/rtp_rtcp_defines.h index 642bba46ca..5856ecbb4b 100644 --- a/modules/rtp_rtcp/include/rtp_rtcp_defines.h +++ b/modules/rtp_rtcp/include/rtp_rtcp_defines.h @@ -45,9 +45,6 @@ const int kBogusRtpRateForAudioRtcp = 8000; // Minimum RTP header size in bytes. const uint8_t kRtpHeaderSize = 12; -// TODO(bugs.webrtc.org/10633): Remove once downstream usage is gone. -enum StorageType { kDontRetransmit, kAllowRetransmission }; - bool IsLegalMidName(absl::string_view name); bool IsLegalRsidName(absl::string_view name); diff --git a/modules/rtp_rtcp/source/rtp_sender.h b/modules/rtp_rtcp/source/rtp_sender.h index f7bdb719cb..4c59d3bc1f 100644 --- a/modules/rtp_rtcp/source/rtp_sender.h +++ b/modules/rtp_rtcp/source/rtp_sender.h @@ -149,15 +149,6 @@ class RTPSender { // Sends packet to |transport_| or to the pacer, depending on configuration. bool SendToNetwork(std::unique_ptr packet); - // TODO(bugs.webrtc.org/10633): Remove once StorageType is gone. - bool SendToNetwork(std::unique_ptr packet, - StorageType storage) { - if (storage == StorageType::kAllowRetransmission) { - packet->set_allow_retransmission(true); - } - return SendToNetwork(std::move(packet)); - } - // Called on update of RTP statistics. void RegisterRtpStatisticsCallback(StreamDataCountersCallback* callback); StreamDataCountersCallback* GetRtpStatisticsCallback() const;