From 168d11cba970e43d7b466c8adc6303e2dbc54ac8 Mon Sep 17 00:00:00 2001 From: Tony Herre Date: Thu, 9 Feb 2023 14:27:14 +0100 Subject: [PATCH] Deprecate TransformableVideoFrame GetAdditionalData It's unused in Chromium and internally - GetMetadata() provides sufficient information. Bug: chromium:1414370 Change-Id: Id93bdccbda85090c1aa2fabf5d6b7b79f2b1e2e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/292862 Reviewed-by: Harald Alvestrand Auto-Submit: Tony Herre Commit-Queue: Tony Herre Cr-Commit-Position: refs/heads/main@{#39287} --- api/frame_transformer_interface.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/frame_transformer_interface.h b/api/frame_transformer_interface.h index fba09d5ff0..92832c00bc 100644 --- a/api/frame_transformer_interface.h +++ b/api/frame_transformer_interface.h @@ -57,9 +57,9 @@ class TransformableVideoFrameInterface : public TransformableFrameInterface { // when the transformation applied to the frame is encryption/decryption, the // additional data holds the serialized generic frame descriptor extension // calculated in webrtc::RtpDescriptorAuthentication. - // TODO(bugs.webrtc.org/11380) remove from interface once - // webrtc::RtpDescriptorAuthentication is exposed in api/. - virtual std::vector GetAdditionalData() const = 0; + // This has been superseeded by GetMetadata() and will be removed shortly. + [[deprecated("https://crbug.com/1414370")]] virtual std::vector + GetAdditionalData() const = 0; virtual const VideoFrameMetadata& GetMetadata() const = 0; // TODO(https://crbug.com/webrtc/14709): Make pure virtual when Chromium MOCK