From 16661ebfd98a31ba365989c73d2dc7a6c27fd1cd Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 3 Jul 2019 11:25:20 +0200 Subject: [PATCH] Fix: report video_bwe_stats as bytes per second, as specified in the unit Bug: webrtc:10138 Change-Id: I5b74e9066f47fde0a72348591524f6e43dfd8799 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142172 Reviewed-by: Mirko Bonadei Commit-Queue: Artem Titov Cr-Commit-Position: refs/heads/master@{#28458} --- .../video/default_video_quality_analyzer.cc | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc b/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc index 97ea3181cb..4e4930747d 100644 --- a/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc +++ b/test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc @@ -26,6 +26,7 @@ namespace { constexpr int kMaxActiveComparisons = 10; constexpr int kFreezeThresholdMs = 150; constexpr int kMicrosPerSecond = 1000000; +constexpr int kBitsInByte = 8; void LogFrameCounters(const std::string& name, const FrameCounters& counters) { RTC_LOG(INFO) << "[" << name << "] Captured : " << counters.captured; @@ -579,15 +580,20 @@ void DefaultVideoQualityAnalyzer::ReportVideoBweResults( const std::string& test_case_name, const VideoBweStats& video_bwe_stats) { ReportResult("available_send_bandwidth", test_case_name, - video_bwe_stats.available_send_bandwidth, "bytesPerSecond"); + video_bwe_stats.available_send_bandwidth / kBitsInByte, + "bytesPerSecond"); ReportResult("transmission_bitrate", test_case_name, - video_bwe_stats.transmission_bitrate, "bytesPerSecond"); + video_bwe_stats.transmission_bitrate / kBitsInByte, + "bytesPerSecond"); ReportResult("retransmission_bitrate", test_case_name, - video_bwe_stats.retransmission_bitrate, "bytesPerSecond"); + video_bwe_stats.retransmission_bitrate / kBitsInByte, + "bytesPerSecond"); ReportResult("actual_encode_bitrate", test_case_name, - video_bwe_stats.actual_encode_bitrate, "bytesPerSecond"); + video_bwe_stats.actual_encode_bitrate / kBitsInByte, + "bytesPerSecond"); ReportResult("target_encode_bitrate", test_case_name, - video_bwe_stats.target_encode_bitrate, "bytesPerSecond"); + video_bwe_stats.target_encode_bitrate / kBitsInByte, + "bytesPerSecond"); } void DefaultVideoQualityAnalyzer::ReportResults(