admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove use of selectors matching Apple private API names.

Browse Source 
This was causing some apps that include WebRTC to be rejected from the
app store.

BUG=webrtc:6382

Review-Url: https://codereview.webrtc.org/2679913002
Cr-Commit-Position: refs/heads/master@{#16462}
This commit is contained in:
kthelgason 2017-02-07 02:48:55 -08:00 committed by Commit bot
parent 4a9a595ab4
commit 1634e16042
4 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/modules/audio_device/ios/objc/RTCAudioSession.h
View File

@ -52,12 +52,12 @@ RTC_EXPORT
/** Called on a system notification thread when AVAudioSession media server
* terminates.
*/
- (void)audioSessionMediaServicesWereLost:(RTCAudioSession *)session;
- (void)audioSessionMediaServerTerminated:(RTCAudioSession *)session;
/** Called on a system notification thread when AVAudioSession media server
* restarts.
*/
- (void)audioSessionMediaServicesWereReset:(RTCAudioSession *)session;
- (void)audioSessionMediaServerReset:(RTCAudioSession *)session;
// TODO(tkchin): Maybe handle SilenceSecondaryAudioHintNotification.

8
webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm
View File

@ -810,18 +810,18 @@ NSInteger const kRTCAudioSessionErrorConfiguration = -2;
- (void)notifyMediaServicesWereLost {
for (auto delegate : self.delegates) {
SEL sel = @selector(audioSessionMediaServicesWereLost:);
SEL sel = @selector(audioSessionMediaServerTerminated:);
if ([delegate respondsToSelector:sel]) {
[delegate audioSessionMediaServicesWereLost:self];
[delegate audioSessionMediaServerTerminated:self];
}
}
}
- (void)notifyMediaServicesWereReset {
for (auto delegate : self.delegates) {
SEL sel = @selector(audioSessionMediaServicesWereReset:);
SEL sel = @selector(audioSessionMediaServerReset:);
if ([delegate respondsToSelector:sel]) {
[delegate audioSessionMediaServicesWereReset:self];
[delegate audioSessionMediaServerReset:self];
}
}
}

4
webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm
View File

@ -64,10 +64,10 @@
}
}
- (void)audioSessionMediaServicesWereLost:(RTCAudioSession *)session {
- (void)audioSessionMediaServerTerminated:(RTCAudioSession *)session {
}
- (void)audioSessionMediaServicesWereReset:(RTCAudioSession *)session {
- (void)audioSessionMediaServerReset:(RTCAudioSession *)session {
}
- (void)audioSession:(RTCAudioSession *)session

4
webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm
View File

@ -32,10 +32,10 @@
previousRoute:(AVAudioSessionRouteDescription *)previousRoute {
}
- (void)audioSessionMediaServicesWereLost:(RTCAudioSession *)session {
- (void)audioSessionMediaServerTerminated:(RTCAudioSession *)session {
}
- (void)audioSessionMediaServicesWereReset:(RTCAudioSession *)session {
- (void)audioSessionMediaServerReset:(RTCAudioSession *)session {
}
- (void)audioSessionShouldConfigure:(RTCAudioSession *)session {