admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove NTDDI_WIN10_RS2 check.

Browse Source 
This check is already present here [1] so when WebRTC will be built
together with Chromium, NTDDI_WIN10_RS2 have to be defined even if WebRTC
doesn't check for it.

[1] - https://cs.chromium.org/chromium/src/base/win/windows_version.cc?l=24&rcl=091d55df46abb677d565d084064f837f819e92d5

Bug: None
Change-Id: I8bbda7b412b5904418f0e400f231dd816e6cbda3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128500
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27199}
This commit is contained in:
Mirko Bonadei 2019-03-18 18:53:53 +01:00 committed by Commit Bot
parent 4e2d76c2cd
commit 16289f6477
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rtc_base/win/windows_version.cc
View File

@ -20,14 +20,6 @@
#error VS 2017 Update 3.2 or higher is required
#endif
#if !defined(NTDDI_WIN10_RS2)
// Windows 10 Creators Update SDK is required to build Chrome. It is important
// to install the 10.0.15063.468 version, released June 2017, because earlier
// versions had bugs and could not build Chrome. See this link for details:
// https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html
#error Creators Update SDK (10.0.15063.468) required.
#endif
#if !defined(WINUWP)
namespace {