admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make ModuleRtpRtcpImpl member variables private.

Browse Source 
This is a follow-up to https://codereview.webrtc.org/2747743002.

BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/2750283003
Cr-Commit-Position: refs/heads/master@{#17271}
This commit is contained in:
nisse 2017-03-16 05:02:53 -07:00 committed by Commit bot
parent 9c192b2b06
commit 150708e061
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h
View File

@ -318,15 +318,6 @@ class ModuleRtpRtcpImpl : public RtpRtcp, public RTCPReceiver::ModuleRtpRtcp {
const Clock* clock() const { return clock_; } const Clock* clock() const { return clock_; }
// TODO(nisse): Demote all member variables to private, as soon as
// downstream code is updated to use the above accessor methods.
RTPSender rtp_sender_;
RTCPSender rtcp_sender_;
RTCPReceiver rtcp_receiver_;
const Clock* const clock_;
private: private:
FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, Rtt); FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, Rtt);
FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, RttForReceiverOnly); FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, RttForReceiverOnly);
@ -338,6 +329,12 @@ class ModuleRtpRtcpImpl : public RtpRtcp, public RTCPReceiver::ModuleRtpRtcp {
bool TimeToSendFullNackList(int64_t now) const; bool TimeToSendFullNackList(int64_t now) const;
RTPSender rtp_sender_;
RTCPSender rtcp_sender_;
RTCPReceiver rtcp_receiver_;
const Clock* const clock_;
const bool audio_; const bool audio_;
int64_t last_process_time_; int64_t last_process_time_;
int64_t last_bitrate_process_time_; int64_t last_bitrate_process_time_;