From 134c6996c8b572a386cae2aafe742dc040eecab6 Mon Sep 17 00:00:00 2001 From: Courtney Edwards Date: Tue, 3 Mar 2020 11:36:35 +0100 Subject: [PATCH] Fix Chromium Roll failing because of -Wrange-loop-construct MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:11398 Change-Id: I51f6f9968b3a94b5fec325e8b5d29fd2bb290ee1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169553 Commit-Queue: Courtney Edwards Reviewed-by: Mirko Bonadei Reviewed-by: Henrik Boström Reviewed-by: Sami Kalliomäki Cr-Commit-Position: refs/heads/master@{#30669} --- pc/channel_unittest.cc | 2 +- sdk/android/src/jni/android_network_monitor.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pc/channel_unittest.cc b/pc/channel_unittest.cc index 8ce3729f45..d5c51ecd8a 100644 --- a/pc/channel_unittest.cc +++ b/pc/channel_unittest.cc @@ -1312,7 +1312,7 @@ class ChannelTest : public ::testing::Test, public sigslot::has_slots<> { void CreateSimulcastContent(const std::vector& rids, typename T::Content* content) { std::vector rid_descriptions; - for (const std::string name : rids) { + for (const std::string& name : rids) { rid_descriptions.push_back(RidDescription(name, RidDirection::kSend)); } diff --git a/sdk/android/src/jni/android_network_monitor.cc b/sdk/android/src/jni/android_network_monitor.cc index d29be44b9c..71a23a86cb 100644 --- a/sdk/android/src/jni/android_network_monitor.cc +++ b/sdk/android/src/jni/android_network_monitor.cc @@ -174,7 +174,7 @@ std::string NetworkInformation::ToString() const { ss << "; underlying_type_for_vpn " << underlying_type_for_vpn; } ss << "; address"; - for (const rtc::IPAddress address : ip_addresses) { + for (const rtc::IPAddress& address : ip_addresses) { ss << " " << address.ToString(); } ss << "]";