From 133b307c7d6c95d8421c918cbb7e4c62cd7a894a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Wed, 13 Mar 2019 12:34:50 +0100 Subject: [PATCH] Delete method VideoStreamDecoder::UpdateRtt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's routed to the old jitter buffer, which is instantiated but unused. Bug: webrtc:7408 Change-Id: I8fe2d8a2bfa6c2119945cc294d17982af4f830cc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127541 Commit-Queue: Niels Moller Reviewed-by: Philip Eliasson Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/master@{#27100} --- video/video_receive_stream.cc | 1 - video/video_stream_decoder.cc | 3 --- video/video_stream_decoder.h | 3 --- 3 files changed, 7 deletions(-) diff --git a/video/video_receive_stream.cc b/video/video_receive_stream.cc index 904e0a509d..0f87d651da 100644 --- a/video/video_receive_stream.cc +++ b/video/video_receive_stream.cc @@ -515,7 +515,6 @@ void VideoReceiveStream::OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms) { RTC_DCHECK_CALLED_SEQUENTIALLY(&module_process_sequence_checker_); frame_buffer_->UpdateRtt(max_rtt_ms); rtp_video_stream_receiver_.UpdateRtt(max_rtt_ms); - video_stream_decoder_->UpdateRtt(max_rtt_ms); } void VideoReceiveStream::OnRttUpdated(int64_t rtt_ms) { diff --git a/video/video_stream_decoder.cc b/video/video_stream_decoder.cc index 8cc9d08fb3..fad7da8f22 100644 --- a/video/video_stream_decoder.cc +++ b/video/video_stream_decoder.cc @@ -114,7 +114,4 @@ void VideoStreamDecoder::OnCompleteFrame(bool is_keyframe, size_t size_bytes, VideoContentType content_type) {} -void VideoStreamDecoder::UpdateRtt(int64_t max_rtt_ms) { - video_receiver_->SetReceiveChannelParameters(max_rtt_ms); -} } // namespace webrtc diff --git a/video/video_stream_decoder.h b/video/video_stream_decoder.h index 114c953c85..54554ebab3 100644 --- a/video/video_stream_decoder.h +++ b/video/video_stream_decoder.h @@ -77,9 +77,6 @@ class VideoStreamDecoder : public VCMReceiveCallback, void RegisterReceiveStatisticsProxy( ReceiveStatisticsProxy* receive_statistics_proxy); - // Called by VideoReceiveStream when stats are updated. - void UpdateRtt(int64_t max_rtt_ms); - private: // Used for all registered callbacks except rendering. rtc::CriticalSection crit_;