From 13044c1b5313a1ab38f89175f095ad600dd3abbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Thu, 5 Oct 2017 12:20:36 +0200 Subject: [PATCH] Reduce time between sync frames for temporal layers vp8 screensharing. This is expected to result in a slight loss of overall quality, but should offset by quicker switching between temporal layers with flaky connections. Bug: webrtc:7694 Change-Id: Ib605802bb59f12773652324ac66cdf4774ae6bb6 Reviewed-on: https://webrtc-review.googlesource.com/6881 Reviewed-by: Ilya Nikolaevskiy Cr-Commit-Position: refs/heads/master@{#20160} --- modules/video_coding/codecs/vp8/screenshare_layers.cc | 4 ++-- .../video_coding/codecs/vp8/screenshare_layers_unittest.cc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/video_coding/codecs/vp8/screenshare_layers.cc b/modules/video_coding/codecs/vp8/screenshare_layers.cc index 9ea9ac9f7f..782dc772fc 100644 --- a/modules/video_coding/codecs/vp8/screenshare_layers.cc +++ b/modules/video_coding/codecs/vp8/screenshare_layers.cc @@ -25,8 +25,8 @@ namespace webrtc { static const int kOneSecond90Khz = 90000; -static const int kMinTimeBetweenSyncs = kOneSecond90Khz * 5; -static const int kMaxTimeBetweenSyncs = kOneSecond90Khz * 10; +static const int kMinTimeBetweenSyncs = kOneSecond90Khz * 2; +static const int kMaxTimeBetweenSyncs = kOneSecond90Khz * 4; static const int kQpDeltaThresholdForSync = 8; static const int kMinBitrateKbpsForQpBoost = 500; diff --git a/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc b/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc index 54f19b8c56..988c1b3a95 100644 --- a/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc +++ b/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc @@ -35,8 +35,8 @@ const int kDefaultQp = 54; const int kDefaultTl0BitrateKbps = 200; const int kDefaultTl1BitrateKbps = 2000; const int kFrameRate = 5; -const int kSyncPeriodSeconds = 5; -const int kMaxSyncPeriodSeconds = 10; +const int kSyncPeriodSeconds = 2; +const int kMaxSyncPeriodSeconds = 4; // Expected flags for corresponding temporal layers. const int kTl0Flags = VP8_EFLAG_NO_UPD_GF | VP8_EFLAG_NO_UPD_ARF |