From 12a47f696544a99c168902d87cc19dd286b6784b Mon Sep 17 00:00:00 2001 From: brandtr Date: Fri, 1 Sep 2017 00:10:27 -0700 Subject: [PATCH] Split up VideoProcessorIntegrationTest files. Changes made: * VideoProcessorIntegrationTest definition goes in .h file. * Member function definitions go into .cc file. * Tests move to _libvpx.cc and _openh264.cc files. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3008913002 Cr-Commit-Position: refs/heads/master@{#19637} --- webrtc/modules/video_coding/BUILD.gn | 9 +- .../test/videoprocessor_integrationtest.cc | 996 +++++++++++------- .../test/videoprocessor_integrationtest.h | 668 +----------- .../videoprocessor_integrationtest_libvpx.cc | 388 +++++++ ...videoprocessor_integrationtest_openh264.cc | 69 ++ 5 files changed, 1132 insertions(+), 998 deletions(-) create mode 100644 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc create mode 100644 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn index d4fb6e4be1..32410f60d9 100644 --- a/webrtc/modules/video_coding/BUILD.gn +++ b/webrtc/modules/video_coding/BUILD.gn @@ -395,6 +395,7 @@ if (rtc_include_tests) { testonly = true sources = [ + "codecs/test/videoprocessor_integrationtest.cc", "codecs/test/videoprocessor_integrationtest.h", ] @@ -435,6 +436,11 @@ if (rtc_include_tests) { "../../sdk:videotoolbox_objc", ] } + + if (!build_with_chromium && is_clang) { + # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). + suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] + } } rtc_source_set("video_coding_modules_tests") { @@ -448,7 +454,8 @@ if (rtc_include_tests) { } sources = [ "codecs/h264/test/h264_impl_unittest.cc", - "codecs/test/videoprocessor_integrationtest.cc", + "codecs/test/videoprocessor_integrationtest_libvpx.cc", + "codecs/test/videoprocessor_integrationtest_openh264.cc", "codecs/vp8/test/vp8_impl_unittest.cc", "codecs/vp9/test/vp9_impl_unittest.cc", ] diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc index 04609bf525..f90e5dd2f6 100644 --- a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc +++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. + * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. * * Use of this source code is governed by a BSD-style license * that can be found in the LICENSE file in the root of the source @@ -10,407 +10,641 @@ #include "webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h" -#include +#include + +#if defined(WEBRTC_ANDROID) +#include "webrtc/modules/video_coding/codecs/test/android_test_initializer.h" +#include "webrtc/sdk/android/src/jni/androidmediadecoder_jni.h" +#include "webrtc/sdk/android/src/jni/androidmediaencoder_jni.h" +#elif defined(WEBRTC_IOS) +#include "webrtc/modules/video_coding/codecs/test/objc_codec_h264_test.h" +#endif + +#include "webrtc/media/engine/internaldecoderfactory.h" +#include "webrtc/media/engine/internalencoderfactory.h" +#include "webrtc/modules/video_coding/codecs/vp8/include/vp8_common_types.h" +#include "webrtc/modules/video_coding/include/video_codec_interface.h" +#include "webrtc/modules/video_coding/include/video_coding.h" +#include "webrtc/rtc_base/checks.h" +#include "webrtc/rtc_base/event.h" +#include "webrtc/rtc_base/file.h" +#include "webrtc/rtc_base/logging.h" +#include "webrtc/rtc_base/ptr_util.h" +#include "webrtc/system_wrappers/include/sleep.h" +#include "webrtc/test/testsupport/fileutils.h" +#include "webrtc/test/testsupport/metrics/video_metrics.h" +#include "webrtc/test/video_codec_settings.h" namespace webrtc { namespace test { namespace { -// Test settings. -// Only allow encoder/decoder to use single core, for predictability. -const bool kUseSingleCore = true; -const bool kVerboseLogging = false; -const bool kHwCodec = false; +const int kPercTargetvsActualMismatch = 20; +const int kBaseKeyFrameInterval = 3000; -// Codec settings. -const bool kResilienceOn = true; +// Parameters from VP8 wrapper, which control target size of key frames. +const float kInitialBufferSize = 0.5f; +const float kOptimalBufferSize = 0.6f; +const float kScaleKeyFrameSize = 0.5f; -// Default sequence is foreman (CIF): may be better to use VGA for resize test. -const int kCifWidth = 352; -const int kCifHeight = 288; -const char kForemanCif[] = "foreman_cif"; -#if !defined(WEBRTC_IOS) -const int kNumFramesShort = 100; -#endif -const int kNumFramesLong = 300; +void VerifyQuality(const QualityMetricsResult& psnr_result, + const QualityMetricsResult& ssim_result, + const QualityThresholds& quality_thresholds) { + EXPECT_GT(psnr_result.average, quality_thresholds.min_avg_psnr); + EXPECT_GT(psnr_result.min, quality_thresholds.min_min_psnr); + EXPECT_GT(ssim_result.average, quality_thresholds.min_avg_ssim); + EXPECT_GT(ssim_result.min, quality_thresholds.min_min_ssim); +} -const std::nullptr_t kNoVisualizationParams = nullptr; +int NumberOfTemporalLayers(const VideoCodec& codec_settings) { + if (codec_settings.codecType == kVideoCodecVP8) { + return codec_settings.VP8().numberOfTemporalLayers; + } else if (codec_settings.codecType == kVideoCodecVP9) { + return codec_settings.VP9().numberOfTemporalLayers; + } else { + return 1; + } +} } // namespace -#if defined(WEBRTC_USE_H264) - -// H264: Run with no packet loss and fixed bitrate. Quality should be very high. -// Note(hbos): The PacketManipulatorImpl code used to simulate packet loss in -// these unittests appears to drop "packets" in a way that is not compatible -// with H264. Therefore ProcessXPercentPacketLossH264, X != 0, unittests have -// not been added. -TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossH264) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecH264, 1, false, false, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 500, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; - rate_profile.num_frames = kNumFramesShort; - - std::vector rc_thresholds; - AddRateControlThresholds(2, 60, 20, 10, 20, 0, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(35.0, 25.0, 0.93, 0.70); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -#endif // defined(WEBRTC_USE_H264) - -// Fails on iOS. See webrtc:4755. -#if !defined(WEBRTC_IOS) - -#if !defined(RTC_DISABLE_VP9) -// VP9: Run with no packet loss and fixed bitrate. Quality should be very high. -// One key frame (first frame only) in sequence. -TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossVP9) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 500, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; - rate_profile.num_frames = kNumFramesShort; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 40, 20, 10, 20, 0, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(37.0, 36.0, 0.93, 0.92); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// VP9: Run with 5% packet loss and fixed bitrate. Quality should be a bit -// lower. One key frame (first frame only) in sequence. -TEST_F(VideoProcessorIntegrationTest, Process5PercentPacketLossVP9) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.05f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 500, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; - rate_profile.num_frames = kNumFramesShort; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 40, 20, 10, 20, 0, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(17.0, 14.0, 0.45, 0.36); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// VP9: Run with no packet loss, with varying bitrate (3 rate updates): -// low to high to medium. Check that quality and encoder response to the new -// target rate/per-frame bandwidth (for each rate update) is within limits. -// One key frame (first frame only) in sequence. -TEST_F(VideoProcessorIntegrationTest, ProcessNoLossChangeBitRateVP9) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 200, 30, 0); - SetRateProfile(&rate_profile, 1, 700, 30, 100); - SetRateProfile(&rate_profile, 2, 500, 30, 200); - rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; - rate_profile.num_frames = kNumFramesLong; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 30, 20, 20, 35, 0, 1, &rc_thresholds); - AddRateControlThresholds(2, 0, 20, 20, 60, 0, 0, &rc_thresholds); - AddRateControlThresholds(0, 0, 25, 20, 40, 0, 0, &rc_thresholds); - - QualityThresholds quality_thresholds(35.5, 30.0, 0.90, 0.85); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// VP9: Run with no packet loss, with an update (decrease) in frame rate. -// Lower frame rate means higher per-frame-bandwidth, so easier to encode. -// At the low bitrate in this test, this means better rate control after the -// update(s) to lower frame rate. So expect less frame drops, and max values -// for the rate control metrics can be lower. One key frame (first frame only). -// Note: quality after update should be higher but we currently compute quality -// metrics averaged over whole sequence run. -TEST_F(VideoProcessorIntegrationTest, - ProcessNoLossChangeFrameRateFrameDropVP9) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 100, 24, 0); - SetRateProfile(&rate_profile, 1, 100, 15, 100); - SetRateProfile(&rate_profile, 2, 100, 10, 200); - rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; - rate_profile.num_frames = kNumFramesLong; - - std::vector rc_thresholds; - AddRateControlThresholds(45, 50, 95, 15, 45, 0, 1, &rc_thresholds); - AddRateControlThresholds(20, 0, 50, 10, 30, 0, 0, &rc_thresholds); - AddRateControlThresholds(5, 0, 30, 5, 25, 0, 0, &rc_thresholds); - - QualityThresholds quality_thresholds(31.5, 18.0, 0.80, 0.43); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// VP9: Run with no packet loss and denoiser on. One key frame (first frame). -TEST_F(VideoProcessorIntegrationTest, ProcessNoLossDenoiserOnVP9) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP9, 1, false, true, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 500, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; - rate_profile.num_frames = kNumFramesShort; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 40, 20, 10, 20, 0, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(36.8, 35.8, 0.92, 0.91); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// Run with no packet loss, at low bitrate. -// spatial_resize is on, for this low bitrate expect one resize in sequence. -// Resize happens on delta frame. Expect only one key frame (first frame). -TEST_F(VideoProcessorIntegrationTest, - DISABLED_ProcessNoLossSpatialResizeFrameDropVP9) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, true, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 50, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesLong + 1; - rate_profile.num_frames = kNumFramesLong; - - std::vector rc_thresholds; - AddRateControlThresholds(228, 70, 160, 15, 80, 1, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(24.0, 13.0, 0.65, 0.37); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// TODO(marpan): Add temporal layer test for VP9, once changes are in -// vp9 wrapper for this. - -#endif // !defined(RTC_DISABLE_VP9) - -// VP8: Run with no packet loss and fixed bitrate. Quality should be very high. -// One key frame (first frame only) in sequence. Setting |key_frame_interval| -// to -1 below means no periodic key frames in test. -TEST_F(VideoProcessorIntegrationTest, ProcessZeroPacketLoss) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 500, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; - rate_profile.num_frames = kNumFramesShort; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 40, 20, 10, 15, 0, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(34.95, 33.0, 0.90, 0.89); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// VP8: Run with 5% packet loss and fixed bitrate. Quality should be a bit -// lower. One key frame (first frame only) in sequence. -TEST_F(VideoProcessorIntegrationTest, Process5PercentPacketLoss) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.05f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 500, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; - rate_profile.num_frames = kNumFramesShort; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 40, 20, 10, 15, 0, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(20.0, 16.0, 0.60, 0.40); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -// VP8: Run with 10% packet loss and fixed bitrate. Quality should be lower. -// One key frame (first frame only) in sequence. -TEST_F(VideoProcessorIntegrationTest, Process10PercentPacketLoss) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.1f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 500, 30, 0); - rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; - rate_profile.num_frames = kNumFramesShort; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 40, 20, 10, 15, 0, 1, &rc_thresholds); - - QualityThresholds quality_thresholds(19.0, 16.0, 0.50, 0.35); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); -} - -#endif // !defined(WEBRTC_IOS) - -// The tests below are currently disabled for Android. For ARM, the encoder -// uses |cpu_speed| = 12, as opposed to default |cpu_speed| <= 6 for x86, -// which leads to significantly different quality. The quality and rate control -// settings in the tests below are defined for encoder speed setting -// |cpu_speed| <= ~6. A number of settings would need to be significantly -// modified for the |cpu_speed| = 12 case. For now, keep the tests below -// disabled on Android. Some quality parameter in the above test has been -// adjusted to also pass for |cpu_speed| <= 12. - -// VP8: Run with no packet loss, with varying bitrate (3 rate updates): -// low to high to medium. Check that quality and encoder response to the new -// target rate/per-frame bandwidth (for each rate update) is within limits. -// One key frame (first frame only) in sequence. -// Too slow to finish before timeout on iOS. See webrtc:4755. -#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS) -#define MAYBE_ProcessNoLossChangeBitRateVP8 \ - DISABLED_ProcessNoLossChangeBitRateVP8 -#else -#define MAYBE_ProcessNoLossChangeBitRateVP8 ProcessNoLossChangeBitRateVP8 +VideoProcessorIntegrationTest::VideoProcessorIntegrationTest() { +#if defined(WEBRTC_VIDEOPROCESSOR_INTEGRATIONTEST_HW_CODECS_ENABLED) && \ + defined(WEBRTC_ANDROID) + InitializeAndroidObjects(); #endif -TEST_F(VideoProcessorIntegrationTest, MAYBE_ProcessNoLossChangeBitRateVP8) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 200, 30, 0); - SetRateProfile(&rate_profile, 1, 800, 30, 100); - SetRateProfile(&rate_profile, 2, 500, 30, 200); - rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; - rate_profile.num_frames = kNumFramesLong; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 45, 20, 10, 15, 0, 1, &rc_thresholds); - AddRateControlThresholds(0, 0, 25, 20, 10, 0, 0, &rc_thresholds); - AddRateControlThresholds(0, 0, 25, 15, 10, 0, 0, &rc_thresholds); - - QualityThresholds quality_thresholds(34.0, 32.0, 0.85, 0.80); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); } -// VP8: Run with no packet loss, with an update (decrease) in frame rate. -// Lower frame rate means higher per-frame-bandwidth, so easier to encode. -// At the bitrate in this test, this means better rate control after the -// update(s) to lower frame rate. So expect less frame drops, and max values -// for the rate control metrics can be lower. One key frame (first frame only). -// Note: quality after update should be higher but we currently compute quality -// metrics averaged over whole sequence run. -// Too slow to finish before timeout on iOS. See webrtc:4755. -#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS) -#define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP8 \ - DISABLED_ProcessNoLossChangeFrameRateFrameDropVP8 +VideoProcessorIntegrationTest::~VideoProcessorIntegrationTest() = default; + +void VideoProcessorIntegrationTest::SetTestConfig(TestConfig* config, + bool hw_codec, + bool use_single_core, + float packet_loss_probability, + std::string filename, + bool verbose_logging) { + config->filename = filename; + config->input_filename = ResourcePath(filename, "yuv"); + // Generate an output filename in a safe way. + config->output_filename = + TempFilename(OutputPath(), "videoprocessor_integrationtest"); + config->networking_config.packet_loss_probability = packet_loss_probability; + config->use_single_core = use_single_core; + config->verbose = verbose_logging; + config->hw_codec = hw_codec; +} + +void VideoProcessorIntegrationTest::SetCodecSettings(TestConfig* config, + VideoCodecType codec_type, + int num_temporal_layers, + bool error_concealment_on, + bool denoising_on, + bool frame_dropper_on, + bool spatial_resize_on, + bool resilience_on, + int width, + int height) { + webrtc::test::CodecSettings(codec_type, &config->codec_settings); + config->codec_settings.width = width; + config->codec_settings.height = height; + switch (config->codec_settings.codecType) { + case kVideoCodecVP8: + config->codec_settings.VP8()->resilience = + resilience_on ? kResilientStream : kResilienceOff; + config->codec_settings.VP8()->numberOfTemporalLayers = + num_temporal_layers; + config->codec_settings.VP8()->denoisingOn = denoising_on; + config->codec_settings.VP8()->errorConcealmentOn = error_concealment_on; + config->codec_settings.VP8()->automaticResizeOn = spatial_resize_on; + config->codec_settings.VP8()->frameDroppingOn = frame_dropper_on; + config->codec_settings.VP8()->keyFrameInterval = kBaseKeyFrameInterval; + break; + case kVideoCodecVP9: + config->codec_settings.VP9()->resilienceOn = resilience_on; + config->codec_settings.VP9()->numberOfTemporalLayers = + num_temporal_layers; + config->codec_settings.VP9()->denoisingOn = denoising_on; + config->codec_settings.VP9()->frameDroppingOn = frame_dropper_on; + config->codec_settings.VP9()->keyFrameInterval = kBaseKeyFrameInterval; + config->codec_settings.VP9()->automaticResizeOn = spatial_resize_on; + break; + case kVideoCodecH264: + config->codec_settings.H264()->frameDroppingOn = frame_dropper_on; + config->codec_settings.H264()->keyFrameInterval = kBaseKeyFrameInterval; + break; + default: + RTC_NOTREACHED(); + break; + } + + config->frame_length_in_bytes = + CalcBufferSize(VideoType::kI420, width, height); +} + +void VideoProcessorIntegrationTest::SetRateProfile( + RateProfile* rate_profile, + int rate_update_index, + int bitrate_kbps, + int framerate_fps, + int frame_index_rate_update) { + rate_profile->target_bit_rate[rate_update_index] = bitrate_kbps; + rate_profile->input_frame_rate[rate_update_index] = framerate_fps; + rate_profile->frame_index_rate_update[rate_update_index] = + frame_index_rate_update; +} + +void VideoProcessorIntegrationTest::AddRateControlThresholds( + int max_num_dropped_frames, + int max_key_frame_size_mismatch, + int max_delta_frame_size_mismatch, + int max_encoding_rate_mismatch, + int max_time_hit_target, + int num_spatial_resizes, + int num_key_frames, + std::vector* rc_thresholds) { + RTC_DCHECK(rc_thresholds); + + rc_thresholds->emplace_back(); + RateControlThresholds* rc_threshold = &rc_thresholds->back(); + rc_threshold->max_num_dropped_frames = max_num_dropped_frames; + rc_threshold->max_key_frame_size_mismatch = max_key_frame_size_mismatch; + rc_threshold->max_delta_frame_size_mismatch = max_delta_frame_size_mismatch; + rc_threshold->max_encoding_rate_mismatch = max_encoding_rate_mismatch; + rc_threshold->max_time_hit_target = max_time_hit_target; + rc_threshold->num_spatial_resizes = num_spatial_resizes; + rc_threshold->num_key_frames = num_key_frames; +} + +// Processes all frames in the clip and verifies the result. +void VideoProcessorIntegrationTest::ProcessFramesAndMaybeVerify( + const RateProfile& rate_profile, + const std::vector* rc_thresholds, + const QualityThresholds* quality_thresholds, + const VisualizationParams* visualization_params) { + // The Android HW codec needs to be run on a task queue, so we simply always + // run the test on a task queue. + rtc::TaskQueue task_queue("VidProc TQ"); + rtc::Event sync_event(false, false); + + SetUpAndInitObjects(&task_queue, rate_profile.target_bit_rate[0], + rate_profile.input_frame_rate[0], visualization_params); + + // Set initial rates. + int rate_update_index = 0; + task_queue.PostTask([this, &rate_profile, rate_update_index] { + processor_->SetRates(rate_profile.target_bit_rate[rate_update_index], + rate_profile.input_frame_rate[rate_update_index]); + }); + + // Process all frames. + int frame_number = 0; + const int num_frames = rate_profile.num_frames; + RTC_DCHECK_GE(num_frames, 1); + while (frame_number < num_frames) { + // In order to not overwhelm the OpenMAX buffers in the Android + // MediaCodec API, we roughly pace the frames here. The downside + // of this is that the encode run will be done in real-time. + // TODO(brandtr): Investigate if this is needed on iOS. + if (config_.hw_codec) { + SleepMs(rtc::kNumMillisecsPerSec / + rate_profile.input_frame_rate[rate_update_index]); + } + + task_queue.PostTask( + [this, frame_number] { processor_->ProcessFrame(frame_number); }); + ++frame_number; + + if (frame_number == + rate_profile.frame_index_rate_update[rate_update_index + 1]) { + ++rate_update_index; + + task_queue.PostTask([this, &rate_profile, rate_update_index] { + processor_->SetRates(rate_profile.target_bit_rate[rate_update_index], + rate_profile.input_frame_rate[rate_update_index]); + }); + } + } + + // Give the VideoProcessor pipeline some time to process the last frame, + // and then release the codecs. + if (config_.hw_codec) { + SleepMs(1 * rtc::kNumMillisecsPerSec); + } + ReleaseAndCloseObjects(&task_queue); + + // Calculate and print rate control statistics. + rate_update_index = 0; + frame_number = 0; + ResetRateControlMetrics(rate_update_index, rate_profile); + std::vector num_dropped_frames; + std::vector num_resize_actions; + sync_event.Reset(); + task_queue.PostTask( + [this, &num_dropped_frames, &num_resize_actions, &sync_event]() { + num_dropped_frames = processor_->NumberDroppedFramesPerRateUpdate(); + num_resize_actions = processor_->NumberSpatialResizesPerRateUpdate(); + sync_event.Set(); + }); + sync_event.Wait(rtc::Event::kForever); + while (frame_number < num_frames) { + UpdateRateControlMetrics(frame_number); + + ++frame_number; + + if (frame_number == + rate_profile.frame_index_rate_update[rate_update_index + 1]) { + PrintAndMaybeVerifyRateControlMetrics(rate_update_index, rc_thresholds, + num_dropped_frames, + num_resize_actions); + ++rate_update_index; + ResetRateControlMetrics(rate_update_index, rate_profile); + } + } + PrintAndMaybeVerifyRateControlMetrics(rate_update_index, rc_thresholds, + num_dropped_frames, num_resize_actions); + + // Calculate and print other statistics. + EXPECT_EQ(num_frames, static_cast(stats_.stats_.size())); + stats_.PrintSummary(); + + // Calculate and print image quality statistics. + // TODO(marpan): Should compute these quality metrics per SetRates update. + QualityMetricsResult psnr_result, ssim_result; + EXPECT_EQ(0, I420MetricsFromFiles(config_.input_filename.c_str(), + config_.output_filename.c_str(), + config_.codec_settings.width, + config_.codec_settings.height, &psnr_result, + &ssim_result)); + if (quality_thresholds) { + VerifyQuality(psnr_result, ssim_result, *quality_thresholds); + } + printf("PSNR avg: %f, min: %f\nSSIM avg: %f, min: %f\n", psnr_result.average, + psnr_result.min, ssim_result.average, ssim_result.min); + printf("\n"); + + // Remove analysis file. + if (remove(config_.output_filename.c_str()) < 0) { + fprintf(stderr, "Failed to remove temporary file!\n"); + } +} + +void VideoProcessorIntegrationTest::CreateEncoderAndDecoder() { + if (config_.hw_codec) { +#if defined(WEBRTC_VIDEOPROCESSOR_INTEGRATIONTEST_HW_CODECS_ENABLED) +#if defined(WEBRTC_ANDROID) + encoder_factory_.reset(new jni::MediaCodecVideoEncoderFactory()); + decoder_factory_.reset(new jni::MediaCodecVideoDecoderFactory()); +#elif defined(WEBRTC_IOS) + EXPECT_EQ(kVideoCodecH264, config_.codec_settings.codecType) + << "iOS HW codecs only support H264."; + encoder_factory_ = CreateObjCEncoderFactory(); + decoder_factory_ = CreateObjCDecoderFactory(); #else -#define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP8 \ - ProcessNoLossChangeFrameRateFrameDropVP8 + RTC_NOTREACHED() << "Only support HW codecs on Android and iOS."; #endif -TEST_F(VideoProcessorIntegrationTest, - MAYBE_ProcessNoLossChangeFrameRateFrameDropVP8) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, - kResilienceOn, kCifWidth, kCifHeight); +#endif // WEBRTC_VIDEOPROCESSOR_INTEGRATIONTEST_HW_CODECS_ENABLED + } else { + // SW codecs. + encoder_factory_.reset(new cricket::InternalEncoderFactory()); + decoder_factory_.reset(new cricket::InternalDecoderFactory()); + } - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 80, 24, 0); - SetRateProfile(&rate_profile, 1, 80, 15, 100); - SetRateProfile(&rate_profile, 2, 80, 10, 200); - rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; - rate_profile.num_frames = kNumFramesLong; + switch (config_.codec_settings.codecType) { + case kVideoCodecVP8: + encoder_ = encoder_factory_->CreateVideoEncoder( + cricket::VideoCodec(cricket::kVp8CodecName)); + decoder_ = decoder_factory_->CreateVideoDecoder(kVideoCodecVP8); + break; + case kVideoCodecVP9: + encoder_ = encoder_factory_->CreateVideoEncoder( + cricket::VideoCodec(cricket::kVp9CodecName)); + decoder_ = decoder_factory_->CreateVideoDecoder(kVideoCodecVP9); + break; + case kVideoCodecH264: + // TODO(brandtr): Generalize so that we support multiple profiles here. + encoder_ = encoder_factory_->CreateVideoEncoder( + cricket::VideoCodec(cricket::kH264CodecName)); + decoder_ = decoder_factory_->CreateVideoDecoder(kVideoCodecH264); + break; + default: + RTC_NOTREACHED(); + break; + } - std::vector rc_thresholds; - AddRateControlThresholds(40, 20, 75, 15, 60, 0, 1, &rc_thresholds); - AddRateControlThresholds(10, 0, 25, 10, 35, 0, 0, &rc_thresholds); - AddRateControlThresholds(0, 0, 20, 10, 15, 0, 0, &rc_thresholds); - - QualityThresholds quality_thresholds(31.0, 22.0, 0.80, 0.65); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); + EXPECT_TRUE(encoder_) << "Encoder not successfully created."; + EXPECT_TRUE(decoder_) << "Decoder not successfully created."; } -// VP8: Run with no packet loss, with 3 temporal layers, with a rate update in -// the middle of the sequence. The max values for the frame size mismatch and -// encoding rate mismatch are applied to each layer. -// No dropped frames in this test, and internal spatial resizer is off. -// One key frame (first frame only) in sequence, so no spatial resizing. -// Too slow to finish before timeout on iOS. See webrtc:4755. -#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS) -#define MAYBE_ProcessNoLossTemporalLayersVP8 \ - DISABLED_ProcessNoLossTemporalLayersVP8 -#else -#define MAYBE_ProcessNoLossTemporalLayersVP8 ProcessNoLossTemporalLayersVP8 -#endif -TEST_F(VideoProcessorIntegrationTest, MAYBE_ProcessNoLossTemporalLayersVP8) { - SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, - kVerboseLogging); - SetCodecSettings(&config_, kVideoCodecVP8, 3, false, true, true, false, - kResilienceOn, kCifWidth, kCifHeight); - - RateProfile rate_profile; - SetRateProfile(&rate_profile, 0, 200, 30, 0); - SetRateProfile(&rate_profile, 1, 400, 30, 150); - rate_profile.frame_index_rate_update[2] = kNumFramesLong + 1; - rate_profile.num_frames = kNumFramesLong; - - std::vector rc_thresholds; - AddRateControlThresholds(0, 20, 30, 10, 10, 0, 1, &rc_thresholds); - AddRateControlThresholds(0, 0, 30, 15, 10, 0, 0, &rc_thresholds); - - QualityThresholds quality_thresholds(32.5, 30.0, 0.85, 0.80); - - ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, - kNoVisualizationParams); +void VideoProcessorIntegrationTest::DestroyEncoderAndDecoder() { + encoder_factory_->DestroyVideoEncoder(encoder_); + decoder_factory_->DestroyVideoDecoder(decoder_); } + +void VideoProcessorIntegrationTest::SetUpAndInitObjects( + rtc::TaskQueue* task_queue, + const int initial_bitrate_kbps, + const int initial_framerate_fps, + const VisualizationParams* visualization_params) { + CreateEncoderAndDecoder(); + + // Create file objects for quality analysis. + analysis_frame_reader_.reset(new YuvFrameReaderImpl( + config_.input_filename, config_.codec_settings.width, + config_.codec_settings.height)); + analysis_frame_writer_.reset(new YuvFrameWriterImpl( + config_.output_filename, config_.codec_settings.width, + config_.codec_settings.height)); + EXPECT_TRUE(analysis_frame_reader_->Init()); + EXPECT_TRUE(analysis_frame_writer_->Init()); + + if (visualization_params) { + const std::string codec_name = + CodecTypeToPayloadString(config_.codec_settings.codecType); + const std::string implementation_type = config_.hw_codec ? "hw" : "sw"; + // clang-format off + const std::string output_filename_base = + OutputPath() + config_.filename + "-" + + codec_name + "-" + implementation_type + "-" + + std::to_string(initial_bitrate_kbps); + // clang-format on + if (visualization_params->save_encoded_ivf) { + rtc::File post_encode_file = + rtc::File::Create(output_filename_base + ".ivf"); + encoded_frame_writer_ = + IvfFileWriter::Wrap(std::move(post_encode_file), 0); + } + if (visualization_params->save_decoded_y4m) { + decoded_frame_writer_.reset(new Y4mFrameWriterImpl( + output_filename_base + ".y4m", config_.codec_settings.width, + config_.codec_settings.height, initial_framerate_fps)); + EXPECT_TRUE(decoded_frame_writer_->Init()); + } + } + + packet_manipulator_.reset(new PacketManipulatorImpl( + &packet_reader_, config_.networking_config, config_.verbose)); + + config_.codec_settings.minBitrate = 0; + config_.codec_settings.startBitrate = initial_bitrate_kbps; + config_.codec_settings.maxFramerate = initial_framerate_fps; + + rtc::Event sync_event(false, false); + task_queue->PostTask([this, &sync_event]() { + processor_ = rtc::MakeUnique( + encoder_, decoder_, analysis_frame_reader_.get(), + analysis_frame_writer_.get(), packet_manipulator_.get(), config_, + &stats_, encoded_frame_writer_.get(), decoded_frame_writer_.get()); + processor_->Init(); + sync_event.Set(); + }); + sync_event.Wait(rtc::Event::kForever); +} + +void VideoProcessorIntegrationTest::ReleaseAndCloseObjects( + rtc::TaskQueue* task_queue) { + rtc::Event sync_event(false, false); + task_queue->PostTask([this, &sync_event]() { + processor_->Release(); + sync_event.Set(); + }); + sync_event.Wait(rtc::Event::kForever); + + // The VideoProcessor must be ::Release()'d before we destroy the codecs. + DestroyEncoderAndDecoder(); + + // Close the analysis files before we use them for SSIM/PSNR calculations. + analysis_frame_reader_->Close(); + analysis_frame_writer_->Close(); + + // Close visualization files. + if (encoded_frame_writer_) { + EXPECT_TRUE(encoded_frame_writer_->Close()); + } + if (decoded_frame_writer_) { + decoded_frame_writer_->Close(); + } +} + +// For every encoded frame, update the rate control metrics. +void VideoProcessorIntegrationTest::UpdateRateControlMetrics(int frame_number) { + RTC_CHECK_GE(frame_number, 0); + + const int tl_idx = TemporalLayerIndexForFrame(frame_number); + ++num_frames_per_update_[tl_idx]; + ++num_frames_total_; + + FrameType frame_type = stats_.stats_[frame_number].frame_type; + float encoded_size_kbits = + stats_.stats_[frame_number].encoded_frame_length_in_bytes * 8.0f / + 1000.0f; + + // Update layer data. + // Update rate mismatch relative to per-frame bandwidth for delta frames. + if (frame_type == kVideoFrameDelta) { + // TODO(marpan): Should we count dropped (zero size) frames in mismatch? + sum_frame_size_mismatch_[tl_idx] += + fabs(encoded_size_kbits - per_frame_bandwidth_[tl_idx]) / + per_frame_bandwidth_[tl_idx]; + } else { + float target_size = (frame_number == 0) ? target_size_key_frame_initial_ + : target_size_key_frame_; + sum_key_frame_size_mismatch_ += + fabs(encoded_size_kbits - target_size) / target_size; + num_key_frames_ += 1; + } + sum_encoded_frame_size_[tl_idx] += encoded_size_kbits; + // Encoding bit rate per temporal layer: from the start of the update/run + // to the current frame. + encoding_bitrate_[tl_idx] = sum_encoded_frame_size_[tl_idx] * + framerate_layer_[tl_idx] / + num_frames_per_update_[tl_idx]; + // Total encoding rate: from the start of the update/run to current frame. + sum_encoded_frame_size_total_ += encoded_size_kbits; + encoding_bitrate_total_ = + sum_encoded_frame_size_total_ * framerate_ / num_frames_total_; + perc_encoding_rate_mismatch_ = + 100 * fabs(encoding_bitrate_total_ - bitrate_kbps_) / bitrate_kbps_; + if (perc_encoding_rate_mismatch_ < kPercTargetvsActualMismatch && + !encoding_rate_within_target_) { + num_frames_to_hit_target_ = num_frames_total_; + encoding_rate_within_target_ = true; + } +} + +// Verify expected behavior of rate control and print out data. +void VideoProcessorIntegrationTest::PrintAndMaybeVerifyRateControlMetrics( + int rate_update_index, + const std::vector* rc_thresholds, + const std::vector& num_dropped_frames, + const std::vector& num_resize_actions) { + printf( + "Rate update #%d:\n" + " Target bitrate : %d\n" + " Encoded bitrate : %f\n" + " Frame rate : %d\n", + rate_update_index, bitrate_kbps_, encoding_bitrate_total_, framerate_); + printf( + " # processed frames : %d\n" + " # frames to convergence: %d\n" + " # dropped frames : %d\n" + " # spatial resizes : %d\n", + num_frames_total_, num_frames_to_hit_target_, + num_dropped_frames[rate_update_index], + num_resize_actions[rate_update_index]); + + const RateControlThresholds* rc_threshold = nullptr; + if (rc_thresholds) { + rc_threshold = &(*rc_thresholds)[rate_update_index]; + + EXPECT_LE(perc_encoding_rate_mismatch_, + rc_threshold->max_encoding_rate_mismatch); + } + if (num_key_frames_ > 0) { + int perc_key_frame_size_mismatch = + 100 * sum_key_frame_size_mismatch_ / num_key_frames_; + printf( + " # key frames : %d\n" + " Key frame rate mismatch: %d\n", + num_key_frames_, perc_key_frame_size_mismatch); + if (rc_threshold) { + EXPECT_LE(perc_key_frame_size_mismatch, + rc_threshold->max_key_frame_size_mismatch); + } + } + + const int num_temporal_layers = + NumberOfTemporalLayers(config_.codec_settings); + for (int i = 0; i < num_temporal_layers; i++) { + int perc_frame_size_mismatch = + 100 * sum_frame_size_mismatch_[i] / num_frames_per_update_[i]; + int perc_encoding_rate_mismatch = + 100 * fabs(encoding_bitrate_[i] - bitrate_layer_[i]) / + bitrate_layer_[i]; + printf( + " Temporal layer #%d:\n" + " Target layer bitrate : %f\n" + " Layer frame rate : %f\n" + " Layer per frame bandwidth : %f\n" + " Layer encoding bitrate : %f\n" + " Layer percent frame size mismatch : %d\n" + " Layer percent encoding rate mismatch: %d\n" + " # frames processed per layer : %d\n", + i, bitrate_layer_[i], framerate_layer_[i], per_frame_bandwidth_[i], + encoding_bitrate_[i], perc_frame_size_mismatch, + perc_encoding_rate_mismatch, num_frames_per_update_[i]); + if (rc_threshold) { + EXPECT_LE(perc_frame_size_mismatch, + rc_threshold->max_delta_frame_size_mismatch); + EXPECT_LE(perc_encoding_rate_mismatch, + rc_threshold->max_encoding_rate_mismatch); + } + } + printf("\n"); + + if (rc_threshold) { + EXPECT_LE(num_frames_to_hit_target_, rc_threshold->max_time_hit_target); + EXPECT_LE(num_dropped_frames[rate_update_index], + rc_threshold->max_num_dropped_frames); + EXPECT_EQ(rc_threshold->num_spatial_resizes, + num_resize_actions[rate_update_index]); + EXPECT_EQ(rc_threshold->num_key_frames, num_key_frames_); + } +} + +// Temporal layer index corresponding to frame number, for up to 3 layers. +int VideoProcessorIntegrationTest::TemporalLayerIndexForFrame( + int frame_number) const { + const int num_temporal_layers = + NumberOfTemporalLayers(config_.codec_settings); + int tl_idx = -1; + switch (num_temporal_layers) { + case 1: + tl_idx = 0; + break; + case 2: + // temporal layer 0: 0 2 4 ... + // temporal layer 1: 1 3 + tl_idx = (frame_number % 2 == 0) ? 0 : 1; + break; + case 3: + // temporal layer 0: 0 4 8 ... + // temporal layer 1: 2 6 + // temporal layer 2: 1 3 5 7 + if (frame_number % 4 == 0) { + tl_idx = 0; + } else if ((frame_number + 2) % 4 == 0) { + tl_idx = 1; + } else if ((frame_number + 1) % 2 == 0) { + tl_idx = 2; + } + break; + default: + RTC_NOTREACHED(); + break; + } + return tl_idx; +} + +// Reset quantities before each encoder rate update. +void VideoProcessorIntegrationTest::ResetRateControlMetrics( + int rate_update_index, + const RateProfile& rate_profile) { + // Set new rates. + bitrate_kbps_ = rate_profile.target_bit_rate[rate_update_index]; + framerate_ = rate_profile.input_frame_rate[rate_update_index]; + const int num_temporal_layers = + NumberOfTemporalLayers(config_.codec_settings); + RTC_DCHECK_LE(num_temporal_layers, kMaxNumTemporalLayers); + for (int i = 0; i < num_temporal_layers; i++) { + float bit_rate_ratio = kVp8LayerRateAlloction[num_temporal_layers - 1][i]; + if (i > 0) { + float bit_rate_delta_ratio = + kVp8LayerRateAlloction[num_temporal_layers - 1][i] - + kVp8LayerRateAlloction[num_temporal_layers - 1][i - 1]; + bitrate_layer_[i] = bitrate_kbps_ * bit_rate_delta_ratio; + } else { + bitrate_layer_[i] = bitrate_kbps_ * bit_rate_ratio; + } + framerate_layer_[i] = + framerate_ / static_cast(1 << (num_temporal_layers - 1)); + } + if (num_temporal_layers == 3) { + framerate_layer_[2] = framerate_ / 2.0f; + } + if (rate_update_index == 0) { + target_size_key_frame_initial_ = + 0.5 * kInitialBufferSize * bitrate_layer_[0]; + } + + // Reset rate control metrics. + for (int i = 0; i < num_temporal_layers; i++) { + num_frames_per_update_[i] = 0; + sum_frame_size_mismatch_[i] = 0.0f; + sum_encoded_frame_size_[i] = 0.0f; + encoding_bitrate_[i] = 0.0f; + // Update layer per-frame-bandwidth. + per_frame_bandwidth_[i] = static_cast(bitrate_layer_[i]) / + static_cast(framerate_layer_[i]); + } + // Set maximum size of key frames, following setting in the VP8 wrapper. + float max_key_size = kScaleKeyFrameSize * kOptimalBufferSize * framerate_; + // We don't know exact target size of the key frames (except for first one), + // but the minimum in libvpx is ~|3 * per_frame_bandwidth| and maximum is + // set by |max_key_size_ * per_frame_bandwidth|. Take middle point/average + // as reference for mismatch. Note key frames always correspond to base + // layer frame in this test. + target_size_key_frame_ = 0.5 * (3 + max_key_size) * per_frame_bandwidth_[0]; + num_frames_total_ = 0; + sum_encoded_frame_size_total_ = 0.0f; + encoding_bitrate_total_ = 0.0f; + perc_encoding_rate_mismatch_ = 0.0f; + num_frames_to_hit_target_ = + rate_profile.frame_index_rate_update[rate_update_index + 1]; + encoding_rate_within_target_ = false; + sum_key_frame_size_mismatch_ = 0.0; + num_key_frames_ = 0; +} + } // namespace test } // namespace webrtc diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h index f14bfd8b09..a3c512b140 100644 --- a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h +++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. + * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. * * Use of this source code is governed by a BSD-style license * that can be found in the LICENSE file in the root of the source @@ -11,81 +11,31 @@ #ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_TEST_VIDEOPROCESSOR_INTEGRATIONTEST_H_ #define WEBRTC_MODULES_VIDEO_CODING_CODECS_TEST_VIDEOPROCESSOR_INTEGRATIONTEST_H_ -#include - -#include #include #include -#include #include -#if defined(WEBRTC_ANDROID) -#include "webrtc/modules/video_coding/codecs/test/android_test_initializer.h" -#include "webrtc/sdk/android/src/jni/androidmediadecoder_jni.h" -#include "webrtc/sdk/android/src/jni/androidmediaencoder_jni.h" -#elif defined(WEBRTC_IOS) -#include "webrtc/modules/video_coding/codecs/test/objc_codec_h264_test.h" -#endif - -#include "webrtc/media/engine/internaldecoderfactory.h" -#include "webrtc/media/engine/internalencoderfactory.h" +#include "webrtc/common_types.h" #include "webrtc/media/engine/webrtcvideodecoderfactory.h" #include "webrtc/media/engine/webrtcvideoencoderfactory.h" #include "webrtc/modules/video_coding/codecs/test/packet_manipulator.h" +#include "webrtc/modules/video_coding/codecs/test/stats.h" #include "webrtc/modules/video_coding/codecs/test/videoprocessor.h" -#include "webrtc/modules/video_coding/codecs/vp8/include/vp8_common_types.h" -#include "webrtc/modules/video_coding/include/video_codec_interface.h" -#include "webrtc/modules/video_coding/include/video_coding.h" #include "webrtc/modules/video_coding/utility/ivf_file_writer.h" -#include "webrtc/rtc_base/checks.h" -#include "webrtc/rtc_base/event.h" -#include "webrtc/rtc_base/file.h" -#include "webrtc/rtc_base/logging.h" -#include "webrtc/rtc_base/ptr_util.h" -#include "webrtc/system_wrappers/include/sleep.h" #include "webrtc/test/gtest.h" -#include "webrtc/test/testsupport/fileutils.h" #include "webrtc/test/testsupport/frame_reader.h" #include "webrtc/test/testsupport/frame_writer.h" -#include "webrtc/test/testsupport/metrics/video_metrics.h" #include "webrtc/test/testsupport/packet_reader.h" -#include "webrtc/test/video_codec_settings.h" -#include "webrtc/typedefs.h" namespace webrtc { namespace test { -const int kMaxNumRateUpdates = 3; -const int kMaxNumTemporalLayers = 3; - -const int kPercTargetvsActualMismatch = 20; -const int kBaseKeyFrameInterval = 3000; - -// Parameters from VP8 wrapper, which control target size of key frames. -const float kInitialBufferSize = 0.5f; -const float kOptimalBufferSize = 0.6f; -const float kScaleKeyFrameSize = 0.5f; - -// Thresholds for the quality metrics. Defaults are maximally minimal. -struct QualityThresholds { - QualityThresholds(double min_avg_psnr, - double min_min_psnr, - double min_avg_ssim, - double min_min_ssim) - : min_avg_psnr(min_avg_psnr), - min_min_psnr(min_min_psnr), - min_avg_ssim(min_avg_ssim), - min_min_ssim(min_min_ssim) {} - double min_avg_psnr; - double min_min_psnr; - double min_avg_ssim; - double min_min_ssim; -}; - // The sequence of bit rate and frame rate changes for the encoder, the frame // number where the changes are made, and the total number of frames for the // test. struct RateProfile { + static const int kMaxNumRateUpdates = 3; + int target_bit_rate[kMaxNumRateUpdates]; int input_frame_rate[kMaxNumRateUpdates]; int frame_index_rate_update[kMaxNumRateUpdates + 1]; @@ -107,6 +57,22 @@ struct RateControlThresholds { int num_key_frames; }; +// Thresholds for the quality metrics. +struct QualityThresholds { + QualityThresholds(double min_avg_psnr, + double min_min_psnr, + double min_avg_ssim, + double min_min_ssim) + : min_avg_psnr(min_avg_psnr), + min_min_psnr(min_min_psnr), + min_avg_ssim(min_avg_ssim), + min_min_ssim(min_min_ssim) {} + double min_avg_psnr; + double min_min_psnr; + double min_avg_ssim; + double min_min_ssim; +}; + // Should video files be saved persistently to disk for post-run visualization? struct VisualizationParams { bool save_encoded_ivf; @@ -124,518 +90,15 @@ struct VisualizationParams { // or breakdown occurs. class VideoProcessorIntegrationTest : public testing::Test { protected: - VideoProcessorIntegrationTest() { -#if defined(WEBRTC_VIDEOPROCESSOR_INTEGRATIONTEST_HW_CODECS_ENABLED) && \ - defined(WEBRTC_ANDROID) - InitializeAndroidObjects(); -#endif - } - ~VideoProcessorIntegrationTest() override = default; - - void CreateEncoderAndDecoder() { - if (config_.hw_codec) { -#if defined(WEBRTC_VIDEOPROCESSOR_INTEGRATIONTEST_HW_CODECS_ENABLED) -#if defined(WEBRTC_ANDROID) - encoder_factory_.reset(new jni::MediaCodecVideoEncoderFactory()); - decoder_factory_.reset(new jni::MediaCodecVideoDecoderFactory()); -#elif defined(WEBRTC_IOS) - EXPECT_EQ(kVideoCodecH264, config_.codec_settings.codecType) - << "iOS HW codecs only support H264."; - encoder_factory_ = CreateObjCEncoderFactory(); - decoder_factory_ = CreateObjCDecoderFactory(); -#else - RTC_NOTREACHED() << "Only support HW codecs on Android and iOS."; -#endif -#endif // WEBRTC_VIDEOPROCESSOR_INTEGRATIONTEST_HW_CODECS_ENABLED - } else { - // SW codecs. - encoder_factory_.reset(new cricket::InternalEncoderFactory()); - decoder_factory_.reset(new cricket::InternalDecoderFactory()); - } - - switch (config_.codec_settings.codecType) { - case kVideoCodecVP8: - encoder_ = encoder_factory_->CreateVideoEncoder( - cricket::VideoCodec(cricket::kVp8CodecName)); - decoder_ = decoder_factory_->CreateVideoDecoder(kVideoCodecVP8); - break; - case kVideoCodecVP9: - encoder_ = encoder_factory_->CreateVideoEncoder( - cricket::VideoCodec(cricket::kVp9CodecName)); - decoder_ = decoder_factory_->CreateVideoDecoder(kVideoCodecVP9); - break; - case kVideoCodecH264: - // TODO(brandtr): Generalize so that we support multiple profiles here. - encoder_ = encoder_factory_->CreateVideoEncoder( - cricket::VideoCodec(cricket::kH264CodecName)); - decoder_ = decoder_factory_->CreateVideoDecoder(kVideoCodecH264); - break; - default: - RTC_NOTREACHED(); - break; - } - - EXPECT_TRUE(encoder_) << "Encoder not successfully created."; - EXPECT_TRUE(decoder_) << "Decoder not successfully created."; - } - - void DestroyEncoderAndDecoder() { - encoder_factory_->DestroyVideoEncoder(encoder_); - decoder_factory_->DestroyVideoDecoder(decoder_); - } - - void SetUpAndInitObjects(rtc::TaskQueue* task_queue, - const int initial_bitrate_kbps, - const int initial_framerate_fps, - const VisualizationParams* visualization_params) { - CreateEncoderAndDecoder(); - - // Create file objects for quality analysis. - analysis_frame_reader_.reset(new YuvFrameReaderImpl( - config_.input_filename, config_.codec_settings.width, - config_.codec_settings.height)); - analysis_frame_writer_.reset(new YuvFrameWriterImpl( - config_.output_filename, config_.codec_settings.width, - config_.codec_settings.height)); - EXPECT_TRUE(analysis_frame_reader_->Init()); - EXPECT_TRUE(analysis_frame_writer_->Init()); - - if (visualization_params) { - const std::string codec_name = - CodecTypeToPayloadString(config_.codec_settings.codecType); - const std::string implementation_type = config_.hw_codec ? "hw" : "sw"; - // clang-format off - const std::string output_filename_base = - OutputPath() + config_.filename + "-" + - codec_name + "-" + implementation_type + "-" + - std::to_string(initial_bitrate_kbps); - // clang-format on - if (visualization_params->save_encoded_ivf) { - rtc::File post_encode_file = - rtc::File::Create(output_filename_base + ".ivf"); - encoded_frame_writer_ = - IvfFileWriter::Wrap(std::move(post_encode_file), 0); - } - if (visualization_params->save_decoded_y4m) { - decoded_frame_writer_.reset(new Y4mFrameWriterImpl( - output_filename_base + ".y4m", config_.codec_settings.width, - config_.codec_settings.height, initial_framerate_fps)); - EXPECT_TRUE(decoded_frame_writer_->Init()); - } - } - - packet_manipulator_.reset(new PacketManipulatorImpl( - &packet_reader_, config_.networking_config, config_.verbose)); - - config_.codec_settings.minBitrate = 0; - config_.codec_settings.startBitrate = initial_bitrate_kbps; - config_.codec_settings.maxFramerate = initial_framerate_fps; - - rtc::Event sync_event(false, false); - task_queue->PostTask([this, &sync_event]() { - processor_ = rtc::MakeUnique( - encoder_, decoder_, analysis_frame_reader_.get(), - analysis_frame_writer_.get(), packet_manipulator_.get(), config_, - &stats_, encoded_frame_writer_.get(), decoded_frame_writer_.get()); - processor_->Init(); - sync_event.Set(); - }); - sync_event.Wait(rtc::Event::kForever); - } - - void ReleaseAndCloseObjects(rtc::TaskQueue* task_queue) { - rtc::Event sync_event(false, false); - task_queue->PostTask([this, &sync_event]() { - processor_->Release(); - sync_event.Set(); - }); - sync_event.Wait(rtc::Event::kForever); - - // The VideoProcessor must be ::Release()'d before we destroy the codecs. - DestroyEncoderAndDecoder(); - - // Close the analysis files before we use them for SSIM/PSNR calculations. - analysis_frame_reader_->Close(); - analysis_frame_writer_->Close(); - - // Close visualization files. - if (encoded_frame_writer_) { - EXPECT_TRUE(encoded_frame_writer_->Close()); - } - if (decoded_frame_writer_) { - decoded_frame_writer_->Close(); - } - } - - // For every encoded frame, update the rate control metrics. - void UpdateRateControlMetrics(int frame_number) { - RTC_CHECK_GE(frame_number, 0); - - const int tl_idx = TemporalLayerIndexForFrame(frame_number); - ++num_frames_per_update_[tl_idx]; - ++num_frames_total_; - - FrameType frame_type = stats_.stats_[frame_number].frame_type; - float encoded_size_kbits = - stats_.stats_[frame_number].encoded_frame_length_in_bytes * 8.0f / - 1000.0f; - - // Update layer data. - // Update rate mismatch relative to per-frame bandwidth for delta frames. - if (frame_type == kVideoFrameDelta) { - // TODO(marpan): Should we count dropped (zero size) frames in mismatch? - sum_frame_size_mismatch_[tl_idx] += - fabs(encoded_size_kbits - per_frame_bandwidth_[tl_idx]) / - per_frame_bandwidth_[tl_idx]; - } else { - float target_size = (frame_number == 0) ? target_size_key_frame_initial_ - : target_size_key_frame_; - sum_key_frame_size_mismatch_ += - fabs(encoded_size_kbits - target_size) / target_size; - num_key_frames_ += 1; - } - sum_encoded_frame_size_[tl_idx] += encoded_size_kbits; - // Encoding bit rate per temporal layer: from the start of the update/run - // to the current frame. - encoding_bitrate_[tl_idx] = sum_encoded_frame_size_[tl_idx] * - framerate_layer_[tl_idx] / - num_frames_per_update_[tl_idx]; - // Total encoding rate: from the start of the update/run to current frame. - sum_encoded_frame_size_total_ += encoded_size_kbits; - encoding_bitrate_total_ = - sum_encoded_frame_size_total_ * framerate_ / num_frames_total_; - perc_encoding_rate_mismatch_ = - 100 * fabs(encoding_bitrate_total_ - bitrate_kbps_) / bitrate_kbps_; - if (perc_encoding_rate_mismatch_ < kPercTargetvsActualMismatch && - !encoding_rate_within_target_) { - num_frames_to_hit_target_ = num_frames_total_; - encoding_rate_within_target_ = true; - } - } - - // Verify expected behavior of rate control and print out data. - void PrintAndMaybeVerifyRateControlMetrics( - int rate_update_index, - const std::vector* rc_thresholds, - const std::vector& num_dropped_frames, - const std::vector& num_resize_actions) { - printf( - "Rate update #%d:\n" - " Target bitrate : %d\n" - " Encoded bitrate : %f\n" - " Frame rate : %d\n", - rate_update_index, bitrate_kbps_, encoding_bitrate_total_, framerate_); - printf( - " # processed frames : %d\n" - " # frames to convergence: %d\n" - " # dropped frames : %d\n" - " # spatial resizes : %d\n", - num_frames_total_, num_frames_to_hit_target_, - num_dropped_frames[rate_update_index], - num_resize_actions[rate_update_index]); - - const RateControlThresholds* rc_threshold = nullptr; - if (rc_thresholds) { - rc_threshold = &(*rc_thresholds)[rate_update_index]; - - EXPECT_LE(perc_encoding_rate_mismatch_, - rc_threshold->max_encoding_rate_mismatch); - } - if (num_key_frames_ > 0) { - int perc_key_frame_size_mismatch = - 100 * sum_key_frame_size_mismatch_ / num_key_frames_; - printf( - " # key frames : %d\n" - " Key frame rate mismatch: %d\n", - num_key_frames_, perc_key_frame_size_mismatch); - if (rc_threshold) { - EXPECT_LE(perc_key_frame_size_mismatch, - rc_threshold->max_key_frame_size_mismatch); - } - } - - const int num_temporal_layers = - NumberOfTemporalLayers(config_.codec_settings); - for (int i = 0; i < num_temporal_layers; i++) { - int perc_frame_size_mismatch = - 100 * sum_frame_size_mismatch_[i] / num_frames_per_update_[i]; - int perc_encoding_rate_mismatch = - 100 * fabs(encoding_bitrate_[i] - bitrate_layer_[i]) / - bitrate_layer_[i]; - printf( - " Temporal layer #%d:\n" - " Target layer bitrate : %f\n" - " Layer frame rate : %f\n" - " Layer per frame bandwidth : %f\n" - " Layer encoding bitrate : %f\n" - " Layer percent frame size mismatch : %d\n" - " Layer percent encoding rate mismatch: %d\n" - " # frames processed per layer : %d\n", - i, bitrate_layer_[i], framerate_layer_[i], per_frame_bandwidth_[i], - encoding_bitrate_[i], perc_frame_size_mismatch, - perc_encoding_rate_mismatch, num_frames_per_update_[i]); - if (rc_threshold) { - EXPECT_LE(perc_frame_size_mismatch, - rc_threshold->max_delta_frame_size_mismatch); - EXPECT_LE(perc_encoding_rate_mismatch, - rc_threshold->max_encoding_rate_mismatch); - } - } - printf("\n"); - - if (rc_threshold) { - EXPECT_LE(num_frames_to_hit_target_, rc_threshold->max_time_hit_target); - EXPECT_LE(num_dropped_frames[rate_update_index], - rc_threshold->max_num_dropped_frames); - EXPECT_EQ(rc_threshold->num_spatial_resizes, - num_resize_actions[rate_update_index]); - EXPECT_EQ(rc_threshold->num_key_frames, num_key_frames_); - } - } - - static void VerifyQuality(const QualityMetricsResult& psnr_result, - const QualityMetricsResult& ssim_result, - const QualityThresholds& quality_thresholds) { - EXPECT_GT(psnr_result.average, quality_thresholds.min_avg_psnr); - EXPECT_GT(psnr_result.min, quality_thresholds.min_min_psnr); - EXPECT_GT(ssim_result.average, quality_thresholds.min_avg_ssim); - EXPECT_GT(ssim_result.min, quality_thresholds.min_min_ssim); - } - - static int NumberOfTemporalLayers(const VideoCodec& codec_settings) { - if (codec_settings.codecType == kVideoCodecVP8) { - return codec_settings.VP8().numberOfTemporalLayers; - } else if (codec_settings.codecType == kVideoCodecVP9) { - return codec_settings.VP9().numberOfTemporalLayers; - } else { - return 1; - } - } - - // Temporal layer index corresponding to frame number, for up to 3 layers. - int TemporalLayerIndexForFrame(int frame_number) { - const int num_temporal_layers = - NumberOfTemporalLayers(config_.codec_settings); - int tl_idx = -1; - switch (num_temporal_layers) { - case 1: - tl_idx = 0; - break; - case 2: - // temporal layer 0: 0 2 4 ... - // temporal layer 1: 1 3 - tl_idx = (frame_number % 2 == 0) ? 0 : 1; - break; - case 3: - // temporal layer 0: 0 4 8 ... - // temporal layer 1: 2 6 - // temporal layer 2: 1 3 5 7 - if (frame_number % 4 == 0) { - tl_idx = 0; - } else if ((frame_number + 2) % 4 == 0) { - tl_idx = 1; - } else if ((frame_number + 1) % 2 == 0) { - tl_idx = 2; - } - break; - default: - RTC_NOTREACHED(); - break; - } - return tl_idx; - } - - // Reset quantities before each encoder rate update. - void ResetRateControlMetrics(int rate_update_index, - const RateProfile& rate_profile) { - // Set new rates. - bitrate_kbps_ = rate_profile.target_bit_rate[rate_update_index]; - framerate_ = rate_profile.input_frame_rate[rate_update_index]; - const int num_temporal_layers = - NumberOfTemporalLayers(config_.codec_settings); - RTC_DCHECK_LE(num_temporal_layers, kMaxNumTemporalLayers); - for (int i = 0; i < num_temporal_layers; i++) { - float bit_rate_ratio = kVp8LayerRateAlloction[num_temporal_layers - 1][i]; - if (i > 0) { - float bit_rate_delta_ratio = - kVp8LayerRateAlloction[num_temporal_layers - 1][i] - - kVp8LayerRateAlloction[num_temporal_layers - 1][i - 1]; - bitrate_layer_[i] = bitrate_kbps_ * bit_rate_delta_ratio; - } else { - bitrate_layer_[i] = bitrate_kbps_ * bit_rate_ratio; - } - framerate_layer_[i] = - framerate_ / static_cast(1 << (num_temporal_layers - 1)); - } - if (num_temporal_layers == 3) { - framerate_layer_[2] = framerate_ / 2.0f; - } - if (rate_update_index == 0) { - target_size_key_frame_initial_ = - 0.5 * kInitialBufferSize * bitrate_layer_[0]; - } - - // Reset rate control metrics. - for (int i = 0; i < num_temporal_layers; i++) { - num_frames_per_update_[i] = 0; - sum_frame_size_mismatch_[i] = 0.0f; - sum_encoded_frame_size_[i] = 0.0f; - encoding_bitrate_[i] = 0.0f; - // Update layer per-frame-bandwidth. - per_frame_bandwidth_[i] = static_cast(bitrate_layer_[i]) / - static_cast(framerate_layer_[i]); - } - // Set maximum size of key frames, following setting in the VP8 wrapper. - float max_key_size = kScaleKeyFrameSize * kOptimalBufferSize * framerate_; - // We don't know exact target size of the key frames (except for first one), - // but the minimum in libvpx is ~|3 * per_frame_bandwidth| and maximum is - // set by |max_key_size_ * per_frame_bandwidth|. Take middle point/average - // as reference for mismatch. Note key frames always correspond to base - // layer frame in this test. - target_size_key_frame_ = 0.5 * (3 + max_key_size) * per_frame_bandwidth_[0]; - num_frames_total_ = 0; - sum_encoded_frame_size_total_ = 0.0f; - encoding_bitrate_total_ = 0.0f; - perc_encoding_rate_mismatch_ = 0.0f; - num_frames_to_hit_target_ = - rate_profile.frame_index_rate_update[rate_update_index + 1]; - encoding_rate_within_target_ = false; - sum_key_frame_size_mismatch_ = 0.0; - num_key_frames_ = 0; - } - - // Processes all frames in the clip and verifies the result. - void ProcessFramesAndMaybeVerify( - const RateProfile& rate_profile, - const std::vector* rc_thresholds, - const QualityThresholds* quality_thresholds, - const VisualizationParams* visualization_params) { - // The Android HW codec needs to be run on a task queue, so we simply always - // run the test on a task queue. - rtc::TaskQueue task_queue("VidProc TQ"); - rtc::Event sync_event(false, false); - - SetUpAndInitObjects(&task_queue, rate_profile.target_bit_rate[0], - rate_profile.input_frame_rate[0], visualization_params); - - // Set initial rates. - int rate_update_index = 0; - task_queue.PostTask([this, &rate_profile, rate_update_index] { - processor_->SetRates(rate_profile.target_bit_rate[rate_update_index], - rate_profile.input_frame_rate[rate_update_index]); - }); - - // Process all frames. - int frame_number = 0; - const int num_frames = rate_profile.num_frames; - RTC_DCHECK_GE(num_frames, 1); - while (frame_number < num_frames) { - // In order to not overwhelm the OpenMAX buffers in the Android - // MediaCodec API, we roughly pace the frames here. The downside - // of this is that the encode run will be done in real-time. - // TODO(brandtr): Investigate if this is needed on iOS. - if (config_.hw_codec) { - SleepMs(rtc::kNumMillisecsPerSec / - rate_profile.input_frame_rate[rate_update_index]); - } - - task_queue.PostTask( - [this, frame_number] { processor_->ProcessFrame(frame_number); }); - ++frame_number; - - if (frame_number == - rate_profile.frame_index_rate_update[rate_update_index + 1]) { - ++rate_update_index; - - task_queue.PostTask([this, &rate_profile, rate_update_index] { - processor_->SetRates( - rate_profile.target_bit_rate[rate_update_index], - rate_profile.input_frame_rate[rate_update_index]); - }); - } - } - - // Give the VideoProcessor pipeline some time to process the last frame, - // and then release the codecs. - if (config_.hw_codec) { - SleepMs(1 * rtc::kNumMillisecsPerSec); - } - ReleaseAndCloseObjects(&task_queue); - - // Calculate and print rate control statistics. - rate_update_index = 0; - frame_number = 0; - ResetRateControlMetrics(rate_update_index, rate_profile); - std::vector num_dropped_frames; - std::vector num_resize_actions; - sync_event.Reset(); - task_queue.PostTask( - [this, &num_dropped_frames, &num_resize_actions, &sync_event]() { - num_dropped_frames = processor_->NumberDroppedFramesPerRateUpdate(); - num_resize_actions = processor_->NumberSpatialResizesPerRateUpdate(); - sync_event.Set(); - }); - sync_event.Wait(rtc::Event::kForever); - while (frame_number < num_frames) { - UpdateRateControlMetrics(frame_number); - - ++frame_number; - - if (frame_number == - rate_profile.frame_index_rate_update[rate_update_index + 1]) { - PrintAndMaybeVerifyRateControlMetrics(rate_update_index, rc_thresholds, - num_dropped_frames, - num_resize_actions); - ++rate_update_index; - ResetRateControlMetrics(rate_update_index, rate_profile); - } - } - PrintAndMaybeVerifyRateControlMetrics(rate_update_index, rc_thresholds, - num_dropped_frames, - num_resize_actions); - - // Calculate and print other statistics. - EXPECT_EQ(num_frames, static_cast(stats_.stats_.size())); - stats_.PrintSummary(); - - // Calculate and print image quality statistics. - // TODO(marpan): Should compute these quality metrics per SetRates update. - QualityMetricsResult psnr_result, ssim_result; - EXPECT_EQ(0, I420MetricsFromFiles(config_.input_filename.c_str(), - config_.output_filename.c_str(), - config_.codec_settings.width, - config_.codec_settings.height, - &psnr_result, &ssim_result)); - if (quality_thresholds) { - VerifyQuality(psnr_result, ssim_result, *quality_thresholds); - } - printf("PSNR avg: %f, min: %f\nSSIM avg: %f, min: %f\n", - psnr_result.average, psnr_result.min, ssim_result.average, - ssim_result.min); - printf("\n"); - - // Remove analysis file. - if (remove(config_.output_filename.c_str()) < 0) { - fprintf(stderr, "Failed to remove temporary file!\n"); - } - } + VideoProcessorIntegrationTest(); + ~VideoProcessorIntegrationTest() override; static void SetTestConfig(TestConfig* config, bool hw_codec, bool use_single_core, float packet_loss_probability, std::string filename, - bool verbose_logging) { - config->filename = filename; - config->input_filename = ResourcePath(filename, "yuv"); - // Generate an output filename in a safe way. - config->output_filename = - TempFilename(OutputPath(), "videoprocessor_integrationtest"); - config->networking_config.packet_loss_probability = packet_loss_probability; - config->use_single_core = use_single_core; - config->verbose = verbose_logging; - config->hw_codec = hw_codec; - } + bool verbose_logging); static void SetCodecSettings(TestConfig* config, VideoCodecType codec_type, @@ -646,54 +109,13 @@ class VideoProcessorIntegrationTest : public testing::Test { bool spatial_resize_on, bool resilience_on, int width, - int height) { - webrtc::test::CodecSettings(codec_type, &config->codec_settings); - config->codec_settings.width = width; - config->codec_settings.height = height; - switch (config->codec_settings.codecType) { - case kVideoCodecVP8: - config->codec_settings.VP8()->resilience = - resilience_on ? kResilientStream : kResilienceOff; - config->codec_settings.VP8()->numberOfTemporalLayers = - num_temporal_layers; - config->codec_settings.VP8()->denoisingOn = denoising_on; - config->codec_settings.VP8()->errorConcealmentOn = error_concealment_on; - config->codec_settings.VP8()->automaticResizeOn = spatial_resize_on; - config->codec_settings.VP8()->frameDroppingOn = frame_dropper_on; - config->codec_settings.VP8()->keyFrameInterval = kBaseKeyFrameInterval; - break; - case kVideoCodecVP9: - config->codec_settings.VP9()->resilienceOn = resilience_on; - config->codec_settings.VP9()->numberOfTemporalLayers = - num_temporal_layers; - config->codec_settings.VP9()->denoisingOn = denoising_on; - config->codec_settings.VP9()->frameDroppingOn = frame_dropper_on; - config->codec_settings.VP9()->keyFrameInterval = kBaseKeyFrameInterval; - config->codec_settings.VP9()->automaticResizeOn = spatial_resize_on; - break; - case kVideoCodecH264: - config->codec_settings.H264()->frameDroppingOn = frame_dropper_on; - config->codec_settings.H264()->keyFrameInterval = kBaseKeyFrameInterval; - break; - default: - RTC_NOTREACHED(); - break; - } - - config->frame_length_in_bytes = - CalcBufferSize(VideoType::kI420, width, height); - } + int height); static void SetRateProfile(RateProfile* rate_profile, int rate_update_index, int bitrate_kbps, int framerate_fps, - int frame_index_rate_update) { - rate_profile->target_bit_rate[rate_update_index] = bitrate_kbps; - rate_profile->input_frame_rate[rate_update_index] = framerate_fps; - rate_profile->frame_index_rate_update[rate_update_index] = - frame_index_rate_update; - } + int frame_index_rate_update); static void AddRateControlThresholds( int max_num_dropped_frames, @@ -703,23 +125,37 @@ class VideoProcessorIntegrationTest : public testing::Test { int max_time_hit_target, int num_spatial_resizes, int num_key_frames, - std::vector* rc_thresholds) { - RTC_DCHECK(rc_thresholds); + std::vector* rc_thresholds); - rc_thresholds->emplace_back(); - RateControlThresholds* rc_threshold = &rc_thresholds->back(); - rc_threshold->max_num_dropped_frames = max_num_dropped_frames; - rc_threshold->max_key_frame_size_mismatch = max_key_frame_size_mismatch; - rc_threshold->max_delta_frame_size_mismatch = max_delta_frame_size_mismatch; - rc_threshold->max_encoding_rate_mismatch = max_encoding_rate_mismatch; - rc_threshold->max_time_hit_target = max_time_hit_target; - rc_threshold->num_spatial_resizes = num_spatial_resizes; - rc_threshold->num_key_frames = num_key_frames; - } + void ProcessFramesAndMaybeVerify( + const RateProfile& rate_profile, + const std::vector* rc_thresholds, + const QualityThresholds* quality_thresholds, + const VisualizationParams* visualization_params); // Config. TestConfig config_; + private: + static const int kMaxNumTemporalLayers = 3; + + void CreateEncoderAndDecoder(); + void DestroyEncoderAndDecoder(); + void SetUpAndInitObjects(rtc::TaskQueue* task_queue, + const int initial_bitrate_kbps, + const int initial_framerate_fps, + const VisualizationParams* visualization_params); + void ReleaseAndCloseObjects(rtc::TaskQueue* task_queue); + void UpdateRateControlMetrics(int frame_number); + void PrintAndMaybeVerifyRateControlMetrics( + int rate_update_index, + const std::vector* rc_thresholds, + const std::vector& num_dropped_frames, + const std::vector& num_resize_actions); + int TemporalLayerIndexForFrame(int frame_number) const; + void ResetRateControlMetrics(int rate_update_index, + const RateProfile& rate_profile); + // Codecs. std::unique_ptr encoder_factory_; VideoEncoder* encoder_; diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc new file mode 100644 index 0000000000..062f662c17 --- /dev/null +++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc @@ -0,0 +1,388 @@ +/* + * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. + * + * Use of this source code is governed by a BSD-style license + * that can be found in the LICENSE file in the root of the source + * tree. An additional intellectual property rights grant can be found + * in the file PATENTS. All contributing project authors may + * be found in the AUTHORS file in the root of the source tree. + */ + +#include "webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h" + +#include + +namespace webrtc { +namespace test { + +namespace { + +// Test settings. +// Only allow encoder/decoder to use single core, for predictability. +const bool kUseSingleCore = true; +const bool kVerboseLogging = false; +const bool kHwCodec = false; + +// Codec settings. +const bool kResilienceOn = true; + +// Default sequence is foreman (CIF): may be better to use VGA for resize test. +const int kCifWidth = 352; +const int kCifHeight = 288; +const char kForemanCif[] = "foreman_cif"; +#if !defined(WEBRTC_IOS) +const int kNumFramesShort = 100; +#endif +const int kNumFramesLong = 300; + +const std::nullptr_t kNoVisualizationParams = nullptr; + +} // namespace + +// Fails on iOS. See webrtc:4755. +#if !defined(WEBRTC_IOS) + +#if !defined(RTC_DISABLE_VP9) +// VP9: Run with no packet loss and fixed bitrate. Quality should be very high. +// One key frame (first frame only) in sequence. +TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossVP9) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 500, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; + rate_profile.num_frames = kNumFramesShort; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 40, 20, 10, 20, 0, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(37.0, 36.0, 0.93, 0.92); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP9: Run with 5% packet loss and fixed bitrate. Quality should be a bit +// lower. One key frame (first frame only) in sequence. +TEST_F(VideoProcessorIntegrationTest, Process5PercentPacketLossVP9) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.05f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 500, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; + rate_profile.num_frames = kNumFramesShort; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 40, 20, 10, 20, 0, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(17.0, 14.0, 0.45, 0.36); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP9: Run with no packet loss, with varying bitrate (3 rate updates): +// low to high to medium. Check that quality and encoder response to the new +// target rate/per-frame bandwidth (for each rate update) is within limits. +// One key frame (first frame only) in sequence. +TEST_F(VideoProcessorIntegrationTest, ProcessNoLossChangeBitRateVP9) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 200, 30, 0); + SetRateProfile(&rate_profile, 1, 700, 30, 100); + SetRateProfile(&rate_profile, 2, 500, 30, 200); + rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; + rate_profile.num_frames = kNumFramesLong; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 30, 20, 20, 35, 0, 1, &rc_thresholds); + AddRateControlThresholds(2, 0, 20, 20, 60, 0, 0, &rc_thresholds); + AddRateControlThresholds(0, 0, 25, 20, 40, 0, 0, &rc_thresholds); + + QualityThresholds quality_thresholds(35.5, 30.0, 0.90, 0.85); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP9: Run with no packet loss, with an update (decrease) in frame rate. +// Lower frame rate means higher per-frame-bandwidth, so easier to encode. +// At the low bitrate in this test, this means better rate control after the +// update(s) to lower frame rate. So expect less frame drops, and max values +// for the rate control metrics can be lower. One key frame (first frame only). +// Note: quality after update should be higher but we currently compute quality +// metrics averaged over whole sequence run. +TEST_F(VideoProcessorIntegrationTest, + ProcessNoLossChangeFrameRateFrameDropVP9) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 100, 24, 0); + SetRateProfile(&rate_profile, 1, 100, 15, 100); + SetRateProfile(&rate_profile, 2, 100, 10, 200); + rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; + rate_profile.num_frames = kNumFramesLong; + + std::vector rc_thresholds; + AddRateControlThresholds(45, 50, 95, 15, 45, 0, 1, &rc_thresholds); + AddRateControlThresholds(20, 0, 50, 10, 30, 0, 0, &rc_thresholds); + AddRateControlThresholds(5, 0, 30, 5, 25, 0, 0, &rc_thresholds); + + QualityThresholds quality_thresholds(31.5, 18.0, 0.80, 0.43); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP9: Run with no packet loss and denoiser on. One key frame (first frame). +TEST_F(VideoProcessorIntegrationTest, ProcessNoLossDenoiserOnVP9) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP9, 1, false, true, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 500, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; + rate_profile.num_frames = kNumFramesShort; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 40, 20, 10, 20, 0, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(36.8, 35.8, 0.92, 0.91); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// Run with no packet loss, at low bitrate. +// spatial_resize is on, for this low bitrate expect one resize in sequence. +// Resize happens on delta frame. Expect only one key frame (first frame). +TEST_F(VideoProcessorIntegrationTest, + DISABLED_ProcessNoLossSpatialResizeFrameDropVP9) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP9, 1, false, false, true, true, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 50, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFramesLong + 1; + rate_profile.num_frames = kNumFramesLong; + + std::vector rc_thresholds; + AddRateControlThresholds(228, 70, 160, 15, 80, 1, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(24.0, 13.0, 0.65, 0.37); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// TODO(marpan): Add temporal layer test for VP9, once changes are in +// vp9 wrapper for this. + +#endif // !defined(RTC_DISABLE_VP9) + +// VP8: Run with no packet loss and fixed bitrate. Quality should be very high. +// One key frame (first frame only) in sequence. Setting |key_frame_interval| +// to -1 below means no periodic key frames in test. +TEST_F(VideoProcessorIntegrationTest, ProcessZeroPacketLoss) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 500, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; + rate_profile.num_frames = kNumFramesShort; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 40, 20, 10, 15, 0, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(34.95, 33.0, 0.90, 0.89); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP8: Run with 5% packet loss and fixed bitrate. Quality should be a bit +// lower. One key frame (first frame only) in sequence. +TEST_F(VideoProcessorIntegrationTest, Process5PercentPacketLoss) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.05f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 500, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; + rate_profile.num_frames = kNumFramesShort; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 40, 20, 10, 15, 0, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(20.0, 16.0, 0.60, 0.40); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP8: Run with 10% packet loss and fixed bitrate. Quality should be lower. +// One key frame (first frame only) in sequence. +TEST_F(VideoProcessorIntegrationTest, Process10PercentPacketLoss) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.1f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 500, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1; + rate_profile.num_frames = kNumFramesShort; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 40, 20, 10, 15, 0, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(19.0, 16.0, 0.50, 0.35); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +#endif // !defined(WEBRTC_IOS) + +// The tests below are currently disabled for Android. For ARM, the encoder +// uses |cpu_speed| = 12, as opposed to default |cpu_speed| <= 6 for x86, +// which leads to significantly different quality. The quality and rate control +// settings in the tests below are defined for encoder speed setting +// |cpu_speed| <= ~6. A number of settings would need to be significantly +// modified for the |cpu_speed| = 12 case. For now, keep the tests below +// disabled on Android. Some quality parameter in the above test has been +// adjusted to also pass for |cpu_speed| <= 12. + +// VP8: Run with no packet loss, with varying bitrate (3 rate updates): +// low to high to medium. Check that quality and encoder response to the new +// target rate/per-frame bandwidth (for each rate update) is within limits. +// One key frame (first frame only) in sequence. +// Too slow to finish before timeout on iOS. See webrtc:4755. +#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS) +#define MAYBE_ProcessNoLossChangeBitRateVP8 \ + DISABLED_ProcessNoLossChangeBitRateVP8 +#else +#define MAYBE_ProcessNoLossChangeBitRateVP8 ProcessNoLossChangeBitRateVP8 +#endif +TEST_F(VideoProcessorIntegrationTest, MAYBE_ProcessNoLossChangeBitRateVP8) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 200, 30, 0); + SetRateProfile(&rate_profile, 1, 800, 30, 100); + SetRateProfile(&rate_profile, 2, 500, 30, 200); + rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; + rate_profile.num_frames = kNumFramesLong; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 45, 20, 10, 15, 0, 1, &rc_thresholds); + AddRateControlThresholds(0, 0, 25, 20, 10, 0, 0, &rc_thresholds); + AddRateControlThresholds(0, 0, 25, 15, 10, 0, 0, &rc_thresholds); + + QualityThresholds quality_thresholds(34.0, 32.0, 0.85, 0.80); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP8: Run with no packet loss, with an update (decrease) in frame rate. +// Lower frame rate means higher per-frame-bandwidth, so easier to encode. +// At the bitrate in this test, this means better rate control after the +// update(s) to lower frame rate. So expect less frame drops, and max values +// for the rate control metrics can be lower. One key frame (first frame only). +// Note: quality after update should be higher but we currently compute quality +// metrics averaged over whole sequence run. +// Too slow to finish before timeout on iOS. See webrtc:4755. +#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS) +#define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP8 \ + DISABLED_ProcessNoLossChangeFrameRateFrameDropVP8 +#else +#define MAYBE_ProcessNoLossChangeFrameRateFrameDropVP8 \ + ProcessNoLossChangeFrameRateFrameDropVP8 +#endif +TEST_F(VideoProcessorIntegrationTest, + MAYBE_ProcessNoLossChangeFrameRateFrameDropVP8) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP8, 1, false, true, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 80, 24, 0); + SetRateProfile(&rate_profile, 1, 80, 15, 100); + SetRateProfile(&rate_profile, 2, 80, 10, 200); + rate_profile.frame_index_rate_update[3] = kNumFramesLong + 1; + rate_profile.num_frames = kNumFramesLong; + + std::vector rc_thresholds; + AddRateControlThresholds(40, 20, 75, 15, 60, 0, 1, &rc_thresholds); + AddRateControlThresholds(10, 0, 25, 10, 35, 0, 0, &rc_thresholds); + AddRateControlThresholds(0, 0, 20, 10, 15, 0, 0, &rc_thresholds); + + QualityThresholds quality_thresholds(31.0, 22.0, 0.80, 0.65); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +// VP8: Run with no packet loss, with 3 temporal layers, with a rate update in +// the middle of the sequence. The max values for the frame size mismatch and +// encoding rate mismatch are applied to each layer. +// No dropped frames in this test, and internal spatial resizer is off. +// One key frame (first frame only) in sequence, so no spatial resizing. +// Too slow to finish before timeout on iOS. See webrtc:4755. +#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS) +#define MAYBE_ProcessNoLossTemporalLayersVP8 \ + DISABLED_ProcessNoLossTemporalLayersVP8 +#else +#define MAYBE_ProcessNoLossTemporalLayersVP8 ProcessNoLossTemporalLayersVP8 +#endif +TEST_F(VideoProcessorIntegrationTest, MAYBE_ProcessNoLossTemporalLayersVP8) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecVP8, 3, false, true, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 200, 30, 0); + SetRateProfile(&rate_profile, 1, 400, 30, 150); + rate_profile.frame_index_rate_update[2] = kNumFramesLong + 1; + rate_profile.num_frames = kNumFramesLong; + + std::vector rc_thresholds; + AddRateControlThresholds(0, 20, 30, 10, 10, 0, 1, &rc_thresholds); + AddRateControlThresholds(0, 0, 30, 15, 10, 0, 0, &rc_thresholds); + + QualityThresholds quality_thresholds(32.5, 30.0, 0.85, 0.80); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +} // namespace test +} // namespace webrtc diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc new file mode 100644 index 0000000000..41e42edee1 --- /dev/null +++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc @@ -0,0 +1,69 @@ +/* + * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. + * + * Use of this source code is governed by a BSD-style license + * that can be found in the LICENSE file in the root of the source + * tree. An additional intellectual property rights grant can be found + * in the file PATENTS. All contributing project authors may + * be found in the AUTHORS file in the root of the source tree. + */ + +#include "webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h" + +#include + +namespace webrtc { +namespace test { + +#if defined(WEBRTC_USE_H264) + +namespace { + +// Test settings. +// Only allow encoder/decoder to use single core, for predictability. +const bool kUseSingleCore = true; +const bool kVerboseLogging = false; +const bool kHwCodec = false; + +// Codec settings. +const bool kResilienceOn = true; + +// Default sequence is foreman (CIF): may be better to use VGA for resize test. +const int kCifWidth = 352; +const int kCifHeight = 288; +const char kForemanCif[] = "foreman_cif"; +const int kNumFrames = 100; + +const std::nullptr_t kNoVisualizationParams = nullptr; + +} // namespace + +// H264: Run with no packet loss and fixed bitrate. Quality should be very high. +// Note(hbos): The PacketManipulatorImpl code used to simulate packet loss in +// these unittests appears to drop "packets" in a way that is not compatible +// with H264. Therefore ProcessXPercentPacketLossH264, X != 0, unittests have +// not been added. +TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossH264) { + SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif, + kVerboseLogging); + SetCodecSettings(&config_, kVideoCodecH264, 1, false, false, true, false, + kResilienceOn, kCifWidth, kCifHeight); + + RateProfile rate_profile; + SetRateProfile(&rate_profile, 0, 500, 30, 0); + rate_profile.frame_index_rate_update[1] = kNumFrames + 1; + rate_profile.num_frames = kNumFrames; + + std::vector rc_thresholds; + AddRateControlThresholds(2, 60, 20, 10, 20, 0, 1, &rc_thresholds); + + QualityThresholds quality_thresholds(35.0, 25.0, 0.93, 0.70); + + ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds, + kNoVisualizationParams); +} + +#endif // defined(WEBRTC_USE_H264) + +} // namespace test +} // namespace webrtc