From 128addb1a20de9a40fea08574fe5b3fb75573b17 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Thu, 31 Mar 2022 14:47:34 +0200 Subject: [PATCH] Update TQ pacer holdback window defaults. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Default holdback-window for non-prio packets is now 5ms, or the expected pacing time for 3 packets if lower. This brings wakeup frequency in line with legacy pacer at medium to low packet rates. Bug: webrtc:10809 Change-Id: I4045c40ae6b6d50f1ea049f3a26768023f77ec3c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257301 Auto-Submit: Erik Språng Reviewed-by: Henrik Boström Commit-Queue: Henrik Boström Cr-Commit-Position: refs/heads/main@{#36397} --- call/rtp_transport_controller_send.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/call/rtp_transport_controller_send.cc b/call/rtp_transport_controller_send.cc index e9a860256d..c5df7d7a18 100644 --- a/call/rtp_transport_controller_send.cc +++ b/call/rtp_transport_controller_send.cc @@ -76,9 +76,8 @@ bool IsRelayed(const rtc::NetworkRoute& route) { RtpTransportControllerSend::PacerSettings::PacerSettings( const FieldTrialsView& trials) : tq_disabled("Disabled"), - holdback_window("holdback_window", PacingController::kMinSleepTime), - holdback_packets("holdback_packets", - TaskQueuePacedSender::kNoPacketHoldback) { + holdback_window("holdback_window", TimeDelta::Millis(5)), + holdback_packets("holdback_packets", 3) { ParseFieldTrial({&tq_disabled, &holdback_window, &holdback_packets}, trials.Lookup("WebRTC-TaskQueuePacer")); }