From 11a922086bea634f95661434278b8b95fef60b04 Mon Sep 17 00:00:00 2001 From: Jonas Olsson Date: Thu, 30 Aug 2018 15:35:15 +0200 Subject: [PATCH] Demote RTC_NOTREACHED in pseudotcp RTT processing to warning. This problem shouldn't be severe enough to require a crash, and it can be triggered by untrusted network data. We'll print a warning instead. Bug: chromium:877790 Change-Id: Ie1f33d85dc7f0ccbbc1d027b73f77b964c6f7e46 Reviewed-on: https://webrtc-review.googlesource.com/96880 Reviewed-by: Per Kjellander Reviewed-by: Niels Moller Commit-Queue: Jonas Olsson Cr-Commit-Position: refs/heads/master@{#24579} --- p2p/base/pseudotcp.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2p/base/pseudotcp.cc b/p2p/base/pseudotcp.cc index 42a4f0cee4..161122b6d5 100644 --- a/p2p/base/pseudotcp.cc +++ b/p2p/base/pseudotcp.cc @@ -729,7 +729,7 @@ bool PseudoTcp::process(Segment& seg) { << " rto: " << m_rx_rto; #endif // _DEBUGMSG } else { - RTC_NOTREACHED(); + RTC_LOG(LS_WARNING) << "rtt < 0"; } }