From 1162ba285df6dd05a6092caa1634cb5cb949bcab Mon Sep 17 00:00:00 2001 From: Johannes Kron Date: Wed, 18 Sep 2019 10:28:33 +0200 Subject: [PATCH] Add max/min encode bitrates to video config of peer connection tests Extend PeerConnectionE2EQualityTestFixture::VideoConfig with min_encode_bitrate_bps and max_encode_bitrate_bps. These are needed to be able to specify the bitrate to be used in tests. Bug: None Change-Id: I8af88020e9b364d924e2cecb2bdcc12bf287394d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153352 Reviewed-by: Artem Titov Reviewed-by: Karl Wiberg Commit-Queue: Johannes Kron Cr-Commit-Position: refs/heads/master@{#29219} --- api/test/peerconnection_quality_test_fixture.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/api/test/peerconnection_quality_test_fixture.h b/api/test/peerconnection_quality_test_fixture.h index 3a654dda45..c75587243c 100644 --- a/api/test/peerconnection_quality_test_fixture.h +++ b/api/test/peerconnection_quality_test_fixture.h @@ -190,6 +190,17 @@ class PeerConnectionE2EQualityTestFixture { // each RtpEncodingParameters of RtpParameters of corresponding // RtpSenderInterface for this video stream. absl::optional temporal_layers_count; + // Sets the maxiumum encode bitrate in bps. If this value is not set, the + // encoder will be capped at an internal maximum value around 2 Mbps + // depending on the resolution. This means that it will never be able to + // utilize a high bandwidth link. + absl::optional max_encode_bitrate_bps; + // Sets the minimum encode bitrate in bps. If this value is not set, the + // encoder will use an internal minimum value. Please note that if this + // value is set higher than the bandwidth of the link, the encoder will + // generate more data than the link can handle regardless of the bandwidth + // estimation. + absl::optional min_encode_bitrate_bps; // If specified the input stream will be also copied to specified file. // It is actually one of the test's output file, which contains copy of what // was captured during the test for this video stream on sender side.