From 1120f7d8956e8997d5778f62233701e2cf73f1d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Wed, 22 Apr 2020 12:19:26 +0200 Subject: [PATCH] Makes the max padding factor default 3.0x MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:11508 Change-Id: Ib2e8f5216140f55a590f43fc52a50058703cc2bf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173750 Commit-Queue: Erik Språng Reviewed-by: Danil Chapovalov Cr-Commit-Position: refs/heads/master@{#31120} --- modules/rtp_rtcp/source/rtp_sender.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/rtp_rtcp/source/rtp_sender.cc b/modules/rtp_rtcp/source/rtp_sender.cc index 76fc74a2b9..36a87c05ed 100644 --- a/modules/rtp_rtcp/source/rtp_sender.cc +++ b/modules/rtp_rtcp/source/rtp_sender.cc @@ -92,8 +92,10 @@ bool HasBweExtension(const RtpHeaderExtensionMap& extensions_map) { } double GetMaxPaddingSizeFactor(const WebRtcKeyValueConfig* field_trials) { - // Effectively no limit by default. - constexpr double kDefaultFactor = IP_PACKET_SIZE; + // Too low factor means RTX payload padding is rarely used and ineffective. + // Too high means we risk interrupting regular media packets. + // In practice, 3x seems to yield reasonable results. + constexpr double kDefaultFactor = 3.0; if (!field_trials) { return kDefaultFactor; }